Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Progress] Multiple progress bar is broken although valid total/value have been set. #757

Closed
ryamaguchi0220 opened this issue May 21, 2019 · 1 comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@ryamaguchi0220
Copy link
Contributor

ryamaguchi0220 commented May 21, 2019

Bug Report

Steps to reproduce

  1. Set total: 1122 and value: [325, 111, 74, 612] in multiple progress.

Expected result

The multiple progress bar is not broken with no console error.

Actual result

The multiple progress bar is broken like this
スクリーンショット 2019-05-21 12 13 13
with a console error.

スクリーンショット 2019-05-21 12 26 46

Testcase

https://jsfiddle.net/d8t69y2s/

Version

2.7.5

@ryamaguchi0220 ryamaguchi0220 changed the title [Progress] Multiple progress bar is broken although set valid total and value. [Progress] Multiple progress bar is broken although valid total/value have been set. May 21, 2019
@exoego
Copy link
Contributor

exoego commented May 21, 2019

This is due to rounding error.

Workaround: You may solve this if precision is set.

precision: 0.01
https://jsfiddle.net/7pns450z/
precision: 100
https://jsfiddle.net/hk2z4bft/

Or include the fixed progress.js until the fix is merged into FUI and released.

<script src="https://cdn.jsdelivr.net/gh/exoego/fomantic-ui@auto-precision-for-multiple-progress/src/definitions/modules/progress.js"></script>

@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript labels May 21, 2019
@lubber-de lubber-de added this to the 2.7.6 milestone Jun 8, 2019
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 10, 2019
@y0hami y0hami closed this as completed in 52bfd66 Jun 16, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

3 participants