Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[form][input] - Unable to setup custom click handler in Input field in form. #770

Closed
ibelar opened this issue May 24, 2019 · 1 comment
Closed

[form][input] - Unable to setup custom click handler in Input field in form. #770

ibelar opened this issue May 24, 2019 · 1 comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug type/duplicate Anything which is a duplicate
Milestone
2.7.6

Comments

@ibelar
Copy link

ibelar commented May 24, 2019 •
edited
Loading

Bug Report

We use to be able to setup our own handler on input field in Form. For example, using a custom File upload input. With latest release 2.7.5, input handler is not execute.
I try both click and change handler and none of them is executing.

Steps to reproduce

  1. Create form and add input
  2. Setup click event listener to input.

Expected result

Event function should be execute.

Actual result

Event function is not execute.

Testcase

https://jsfiddle.net/ibelar/4q02z7u1/

Version

2.7.5
@ibelar ibelar mentioned this issue May 24, 2019
Closed
@lubber-de
Copy link
Member

Duplicate of #746
Fixed by #767
See your adjusted fiddle here: https://jsfiddle.net/pua2e7bv/

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug type/duplicate Anything which is a duplicate lang/javascript Anything involving JavaScript labels May 24, 2019
@lubber-de lubber-de added this to the 2.7.6 milestone May 24, 2019
@lubber-de lubber-de mentioned this issue May 24, 2019
Merged
y0hami pushed a commit that referenced this issue Jun 10, 2019
@lubber-de
fix(form): stop propagation only when dirty event was triggered and p…
2b33903 
…revent default action

Closes #746, #770, #786, atk4/ui#718
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 10, 2019
@y0hami y0hami closed this as completed Jun 16, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug type/duplicate Anything which is a duplicate
Projects
None yet
Milestone
2.7.6
Development

No branches or pull requests
3 participants
@ibelar @y0hami @lubber-de