Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large dropdown alignment #837

Closed
princeandrew01 opened this issue Jun 26, 2019 · 2 comments
Closed

Large dropdown alignment #837

princeandrew01 opened this issue Jun 26, 2019 · 2 comments
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.7

Comments

@princeandrew01
Copy link

princeandrew01 commented Jun 26, 2019 •
edited
Loading

Bug Report

I noticed this issue when i was using the login template. The template, had the form set to large and I noticed alignment for the dropdown icon and clearable icon is not vertically aligned.

Steps to reproduce

  1. Create any clearable dropdown and put it in a large form

Expected result

  1. Both icons should be aligned

Actual result

  1. Icons are not aligned correctly.

Testcase

https://jsfiddle.net/dr4omLq7/9/

Screenshot (when possible)

image

Version

2.7.6
@prudho prudho added tag/good-first-issue Good issues for new starters to try type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Jun 28, 2019
@prudho
Copy link
Contributor

prudho commented Jun 28, 2019

Yes, it seems to happen on every size form's dropdowns but medium.

@prudho prudho mentioned this issue Jun 28, 2019
Merged
@prudho prudho added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed tag/good-first-issue Good issues for new starters to try labels Jun 28, 2019
@prudho
Copy link
Contributor

prudho commented Jun 28, 2019

Fixed by #838.

@lubber-de lubber-de added this to the 2.7.7 milestone Jul 22, 2019
@y0hami y0hami closed this as completed in 6b33c3d Jul 28, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jul 29, 2019
@lubber-de lubber-de mentioned this issue Oct 4, 2019
Merged
y0hami pushed a commit that referenced this issue Oct 18, 2019
@lubber-de
fix(dropdown): dont adjustment dropdown icon when inside a label button
c65aba7 
Since 2.7.7 the dropdown icon adjustments got increased specificity by #838
Unfortunately this also had impact if the dropdown was used in combination with a labeled button
I had to revert the specificity increase, but the additional :not(labeled) fixes the previous issues as well (and keeping the additional .icon would have messed up general dropdowns in combination :not(.labeled) then.
So this PR should fix all three issues now (tested by using the fiddles from the original issues and modding via developer console tools)


Closes #1058 #837 #458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.7
Development

No branches or pull requests
3 participants
@prudho @princeandrew01 @lubber-de