Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTLCSS breaks flag elements #859

Closed
danthedeckie opened this issue Jul 8, 2019 · 0 comments
Closed

RTLCSS breaks flag elements #859

danthedeckie opened this issue Jul 8, 2019 · 0 comments
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@danthedeckie
Copy link
Contributor

Bug Report

RTLCSS which creates the Right-To-Left language support versions (semantic.rtl.css) incorrectly converts background-position: 0 ... to background-position: 100% .... Which breaks the flags.

This is expected behaviour in RTLCSS, see:

MohammadYounes/rtlcss#109

And the correct solution is to tell RTLCSS to ignore that section.

Steps to reproduce

  1. Include the semantic.rtl.css version.
  2. Use a <i class="fr flag"></i> or any other flag which has a background-position:0

Expected result

The flag in the background of an i tag.

Actual result

Empty space where the flag should be.

Testcase

https://jsfiddle.net/1f4qbLa7/
(Although as the RTL version is not available on CDNJS, I copied one of the broken declarations into the CSS file for you to see the problem.

Version

2.x -> All including b3501f9 at least.

danthedeckie added a commit to danthedeckie/Fomantic-UI that referenced this issue Jul 8, 2019
@y0hami y0hami added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Jul 8, 2019
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jul 8, 2019
@lubber-de lubber-de added this to the 2.7.7 milestone Jul 8, 2019
@y0hami y0hami closed this as completed in 40ae7aa Jul 28, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

3 participants