Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown] should have onBeforeAdd() callback #951

Open
sohaibalam67 opened this issue Aug 23, 2019 · 0 comments
Open

[Dropdown] should have onBeforeAdd() callback #951

sohaibalam67 opened this issue Aug 23, 2019 · 0 comments
Labels
lang/javascript Anything involving JavaScript state/has-pr An issue which has a related PR open type/feat Any feature requests or improvements

Comments

@sohaibalam67
Copy link

sohaibalam67 commented Aug 23, 2019 •
edited

Feature Request

Description

onAdd() is called for multiple select dropdown which only receives the added value. There is no way to modify the value itself before it is added.

Use Case

I'm making a custom multiple select dropdown component for tags. Tags could be selected from the dropdown and can also be typed into the dropdown component. So the component is supposed to convert the value to slug. The value should be reflected in the UI as well (the label should be a slug), which doesn't happen now.
If onBeforeAdd() is supported, it would be possible to slugify the value in it.
@y0hami y0hami added tag/good-first-issue Good issues for new starters to try tag/help-wanted Issues which need help to fix or implement type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript labels Aug 23, 2019
vibridi added a commit to vibridi/Fomantic-UI that referenced this issue Sep 11, 2019
@vibridi
feat(dropdown): add onBeforeAdd callback
0dbefa6 
Add onBeforeAdd callback to dropdown module

Closes fomantic#951
@vibridi vibridi mentioned this issue Sep 12, 2019
Draft
@y0hami y0hami removed tag/good-first-issue Good issues for new starters to try tag/help-wanted Issues which need help to fix or implement labels Sep 13, 2019
vibridi added a commit to vibridi/Fomantic-UI that referenced this issue Sep 26, 2019
@vibridi
feat(dropdown): add onBeforeAdd callback
9f7c43f 
Add onBeforeAdd callback to dropdown module

Closes fomantic#951
@lubber-de lubber-de added the state/has-pr An issue which has a related PR open label Sep 30, 2019
vibridi added a commit to vibridi/Fomantic-UI that referenced this issue Oct 6, 2019
@vibridi
feat(dropdown): add onBeforeAdd callback
77ba7f2 
Add onBeforeAdd callback to dropdown module

Closes fomantic#951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript state/has-pr An issue which has a related PR open type/feat Any feature requests or improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@y0hami @lubber-de @sohaibalam67