feat(flags): add alias for czech #2744
Conversation
lubber-de
added
type/feat
lubber-de
changed the title
lubber-de
removed
the
state/awaiting-reviews
|
@lubber-de Do I need to add it to the docs as well? |
That would be very nice, indeed 😉 |
introduced in fomantic/Fomantic-UI#2744
lubber-de
added
the
state/has-docs
| @@ -396,7 +396,7 @@ | |||
| @1f1e8-1f1ff: { | |||
| countrycode: cz; | |||
| class: czechia; | |||
| aliasClass: false; | |||
| aliasClass: czech; | |||
There was a problem hiding this comment.
I wonder what is the motivation and consistency behind this change. czech itself is a language and for other countries there is nothing like french class.
Shouldn't this be czech_republic (consistent with united_states for example)?
There was a problem hiding this comment.
@mvorisek
I trust in your decision here as you are a czech native speaker 🙂 , so if you think this is wrong i am fine by reverting or changing the alias name as you think it would be correct.
And your reasons are valid. Sorry for merging this too quick
So what should we do? Revert or Rename?
There was a problem hiding this comment.
In general I would prefer the data from some external/consistent/popular source, but if the data are managed by Fomantic-UI, it should be renamed to czech_republic. Czechia is short form of Czech Republic introduced in 2006 - https://kafkadesk.org/2019/04/19/czech-republic-vs-czechia-a-linguistic-riddle/ but the long form is still used a lot.
There was a problem hiding this comment.
Fixed by #2746 and docs by fomantic/Fomantic-UI-Docs#453
Corrects #452 as discussed in fomantic/Fomantic-UI#2744 (comment)
Corrects #2744 as discussed in #2744 (comment)
Description
Testcase
Screenshot (if possible)
Closes
#, #, #