Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Make colors work on striped, basic, selectable, stacked, definition #332

Merged
merged 1 commit into from
Jan 4, 2019
Merged

[Table] Make colors work on striped, basic, selectable, stacked, definition #332

merged 1 commit into from
Jan 4, 2019

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 30, 2018 •
edited
Loading

Description

Table fixes:

  • on striped tables any additional color like error on rows were ignored
  • definition tables still had their column color set when stacked
  • rows on selectable, basic, striped tables did not work everytime
  • some single color cells on those tables had their background lost

That is now fixed by proper specificity.

Btw, all of above issues are still the case in SUI 2.4.1, they are not related to the dynamic color PR, nor the !important removements we implemented in FUI 2.7.x

Testcase

http://jsfiddle.net/nv6q8d5e/

Closes

Semantic-Org/Semantic-UI#5318

@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews 🐛 bugfix labels Dec 30, 2018
@lubber-de lubber-de added this to the 2.7.x milestone Dec 30, 2018
@lubber-de lubber-de mentioned this pull request Dec 30, 2018
Open
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug tag/sui-issue Taken from an existing Issue/PR of SUI and removed 🐛 bugfix labels Dec 30, 2018
@ColinFrick
Copy link
Member

Should a green striped table be always the same color? Or should the striping be green (green, dark green, green, etc.)?

@y0hami
Copy link
Member

y0hami commented Dec 31, 2018

@ColinFrick Good point, that would make more sense since it is "green striped" 🤔

@lubber-de
Copy link
Member Author

@ColinFrick @hammy2899 This is a good idea, but would be a new feature (supporting any color in combination with striped table to create "colored stripes").
This PR only covers single colored tr/td elements which override a striped table background.

ColinFrick
ColinFrick approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de I agree, let‘s make a separate PR/Feature Request for that

y0hami
y0hami approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 92e1e99 into fomantic:develop Jan 4, 2019
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 4, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 4, 2019
@lubber-de lubber-de deleted the fix/5318/table_specificity branch January 4, 2019 14:32
@y0hami y0hami mentioned this pull request Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami y0hami approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lubber-de @ColinFrick @y0hami