[Form,Segment] Inverted variants should get inverted loader properly #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
lubber-de
removed
the
state/awaiting-reviews
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a form or segment is inverted, the
loadingclass is still styled as for normal variants (white dimmer).This PR now shows a black dimmer for inverted forms/segments with white loader color.
It also removes a bug where any textual segment content was completely invisble.
Testcase
http://jsfiddle.net/zvs0fmh3/
Remove CSS to see previous behavior
Screenshot
Before
After
Closes
Semantic-Org/Semantic-UI#5656