Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown]: Template for select-dropdown did not use classname-property from settings #358

Conversation

lubber-de
Copy link
Member

Description

Testcase

In case a dropdown should be initiated out of a select -tag, the html was created via a template. This template however did not use classname settings from the settings.className property list, but had them hardcoded instead.

Screenshot

Given a very (very! 🤣 ) simple example
Two dropdowns, one from select, one from div:

<select class="ui dropdown"></select>
<div class="ui dropdown"></div>

Both initiated by

$('.ui.dropdown').dropdown({
        className : {
            menu: 'custom-hint-box menu',
            selection: 'custom-select'
        }
    });

In the DOM Inspector you will recognize the difference: The className setting is not applied to the dropdown made out of the select-tag

Unfixed

image

Fixed

image

Closes

Semantic-Org/Semantic-UI#3603

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Jan 4, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Jan 4, 2019
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 26d6689 into fomantic:develop Jan 4, 2019
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 4, 2019
@lubber-de lubber-de added lang/javascript Anything involving JavaScript and removed lang/css Anything involving CSS labels Jan 4, 2019
@lubber-de lubber-de deleted the fix/3603/use_classname_settings_in_template branch January 4, 2019 13:56
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 4, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants