[Dropdown]: Template for select-dropdown did not use classname-property from settings #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testcase
In case a dropdown should be initiated out of a
select
-tag, the html was created via a template. This template however did not use classname settings from thesettings.className
property list, but had them hardcoded instead.Screenshot
Given a very (very! 🤣 ) simple example
Two dropdowns, one from select, one from div:
Both initiated by
In the DOM Inspector you will recognize the difference: The className setting is not applied to the dropdown made out of the select-tag
Unfixed
Fixed
Closes
Semantic-Org/Semantic-UI#3603