[Dropdown] Allow a real zero to be a selectable value in 'set selected' #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
This was referenced Jan 8, 2019
lubber-de
removed
the
state/awaiting-reviews
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When dropdown list has an entry with given value "0", is is not selectable via
set selectedmethodIn the code, there already was a triple equal check, but this made a real 0 invalid resulting in always comparing String to Number (which of course is false)
Testcase
Unfixed (from original SUI issue)
http://jsfiddle.net/budiadiono/fcsbashq/1/
Fixed
http://jsfiddle.net/g0f7y9pq/
Closes
Semantic-Org/Semantic-UI#5354
Semantic-Org/Semantic-UI#5638