[Label] Content in floating labels should not wrap whitespace #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so centered to the top right corner
lubber-de
added
type/feat
This was referenced Jan 17, 2019
|
I also prepared more enhancements by introducing: .ui.left.floating.label {}
.ui.left.aligned.floating.label {}
.ui.right.aligned.floating.label {}
Should i commit this here or submit a new PR (which will depend on merging this one first) ? |
|
@lubber-de separate PR. |
OK, will do right after this one has been merged |
lubber-de
removed
the
state/awaiting-reviews
y0hami
pushed a commit
that referenced
this pull request
Jan 22, 2019
As announced in #404 (comment) this PR adds the possibility to align a floating label to the left or right. This is especially useful if the label has got larger content, so it is getting more clear where the label belongs to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a
floating labelhad whitespace inside, especially when including icons, it did not stay inline. This happens for every whitespace.To make it still look consistent even if the label content is a bit larger, i also made the label centered to the top right corner of the parent element,
Testcase
http://jsfiddle.net/k1qp7dgv/3/
Remove CSS to see the issue
Screenshot
Before
After
Closes
Semantic-Org/Semantic-UI#4217
Semantic-Org/Semantic-UI#4155