Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Label] Introducing bottom floating label #430

Merged
merged 1 commit into from
Jan 28, 2019
Merged

[Label] Introducing bottom floating label #430

merged 1 commit into from
Jan 28, 2019

Conversation

lubber-de
Copy link
Member

Description

In addition to #418 and suggested in #429 by @etshy this PR adds support to all .floating.label variants to be shown at the bottom instead of the top

.ui.bottom.floating.label{}
.ui.bottom.left.floating.label{}
.ui.bottom.left.aligned.floating.label{}
.ui.bottom.right.floating.label{}
.ui.bottom.right.aligned.floating.label{}

Testcase

http://jsfiddle.net/tjuwcr8h/

Screenshot

image

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 27, 2019
@lubber-de lubber-de added this to the 2.7.2 milestone Jan 27, 2019
@lubber-de lubber-de added the state/awaiting-docs Pull requests which need doc changes/additions label Jan 27, 2019
y0hami
y0hami approved these changes Jan 27, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 8e71c86 into fomantic:develop Jan 28, 2019
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jan 28, 2019
@lubber-de lubber-de deleted the bottom_floating_label branch January 28, 2019 13:35
@lubber-de lubber-de mentioned this pull request Jan 28, 2019
Merged
@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Jan 28, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami y0hami approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lubber-de @ColinFrick @y0hami