[Shape] Fix 3D flip starting zoom, fix nested shapes, ignore child elements with class 'active' #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggered, also centralized flip method to shorten code
lubber-de
added
type/bug
This was referenced Feb 7, 2019
lubber-de
added
the
state/on-hold
|
🤔 Not completely satisfied with the transition between different sizes. |
lubber-de
removed
the
state/on-hold
|
Fixed the transition if shape sides differ in size.
|
y0hami
removed
state/awaiting-reviews
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following issues:
Whenever a shape had child elements which also had the
activeclass set (either from another element likemenuor a nested shape but not the "own"active side), the whole animation was messed up (see screenshots/testcase)Therefore nested shape elements were not working
The Flip animations always started with an hard increased size to gain the 3d-Cube effect. But it still looked misleading instead of a smooth transition. Reason for this was, how shape dealt with translateZ. The fix also reduced the amount of needed code 🙂
Testcase
Fixed
http://jsfiddle.net/qtL0dkr3/
Broken
http://jsfiddle.net/mpkjave0/1/
Screenshot
Nested shapes
Flip Animation
Closes
Semantic-Org/Semantic-UI#4704
Semantic-Org/Semantic-UI#4699
Semantic-Org/Semantic-UI#5127