Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Label] Make corner icon position absolute to support other tags for label like <button> #520

Merged
merged 1 commit into from
Feb 26, 2019
Merged

[Label] Make corner icon position absolute to support other tags for label like <button> #520

merged 1 commit into from
Feb 26, 2019

Conversation

lubber-de
Copy link
Member

Description

By making the icon inside a corner label position absolute, its positioning is not modified anymore, if the corner label was used inside a <button> tag

Testcase

The ui corner label is used in a <button> tag instead of an a

<button class="ui left corner label">
    <i class="heart icon"></i>
</button>

Current case

https://jsfiddle.net/moshfeu/h4582kbc/3/

Adjusted

https://jsfiddle.net/Lfha3wnb/1/

Screenshot (current case)

Closes

#518
Semantic-Org/Semantic-UI-React#3462

@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews 📝 needs test case labels Feb 25, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Feb 25, 2019
@lubber-de lubber-de mentioned this pull request Feb 25, 2019
Closed
@lubber-de lubber-de added type/feat Any feature requests or improvements and removed 📝 needs test case labels Feb 25, 2019
ColinFrick
ColinFrick approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 26, 2019
@y0hami y0hami merged commit 4c411ab into fomantic:develop Feb 26, 2019
@lubber-de lubber-de deleted the fix/518/corner_labels_in_buttons branch February 26, 2019 08:46
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.3 Feb 26, 2019
@y0hami y0hami mentioned this pull request Apr 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshfeu moshfeu moshfeu approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@y0hami y0hami y0hami approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lubber-de @moshfeu @ColinFrick @y0hami