-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The TTSPlugin interface has a typo #259
Comments
i'm happy to take this on. however, it has downstream effects on at least Rox and anywhere else the lib is imported. how do you recommend fixing across all usage sites where the interface is being implemented? |
I recommend adding the correct method and keeping the old one (with a deprecation notice). Then, all implementations will need to implement the new method name and maintain the old one as an "alias" until the deprecation is complete. Leaving all known implementations here, for reference: https://github.com/fonoster/fonoster/tree/main/mods/googletts |
Issue still open but has been already merged in pull/264/commits Should this issue be closed or something is missing ? |
Good catch. There is no reason to keep this open. Thanks |
Describe the bug
There is a typo in the TTSPlugin interface in the package
@fonoster/tts
. The name of the functionsynthetize
is a typo and should be renamed assynthesize.
To Reproduce
NA
Expected behavior
NA
Screenshots
NA
System information (please complete the following):
NA
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: