Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The TTSPlugin interface has a typo #259

Closed
psanders opened this issue Jan 18, 2022 · 4 comments
Closed

The TTSPlugin interface has a typo #259

psanders opened this issue Jan 18, 2022 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@psanders
Copy link
Member

Describe the bug

There is a typo in the TTSPlugin interface in the package@fonoster/tts. The name of the function synthetize is a typo and should be renamed as synthesize.

To Reproduce
NA

Expected behavior
NA

Screenshots
NA

System information (please complete the following):
NA

Additional context
Add any other context about the problem here.

@psanders psanders added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 18, 2022
@gad2103
Copy link
Contributor

gad2103 commented Jan 21, 2022

i'm happy to take this on. however, it has downstream effects on at least Rox and anywhere else the lib is imported. how do you recommend fixing across all usage sites where the interface is being implemented?

@psanders
Copy link
Member Author

I recommend adding the correct method and keeping the old one (with a deprecation notice). Then, all implementations will need to implement the new method name and maintain the old one as an "alias" until the deprecation is complete.

Leaving all known implementations here, for reference:

https://github.com/fonoster/fonoster/tree/main/mods/googletts
https://github.com/fonoster/pollytts
https://github.com/fonoster/fonoster/tree/main/mods/marytts

psanders added a commit that referenced this issue Jan 24, 2022
@BrayanMnz
Copy link
Contributor

Issue still open but has been already merged in pull/264/commits

Should this issue be closed or something is missing ?

@psanders
Copy link
Member Author

Issue still open but has been already merged in pull/264/commits

Should this issue be closed or something is missing ?

Good catch. There is no reason to keep this open. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants