Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binder progress and logs to status tab #2523

Merged
merged 4 commits into from
Apr 10, 2023
Merged

Add binder progress and logs to status tab #2523

merged 4 commits into from
Apr 10, 2023

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Apr 9, 2023

When you click "Edit or run this notebook" on an HTML export, then Binder, it can take some time to start. Like we discovered in the past, long waiting times should be broken down into individual steps, and more information is good! E.g. #2399 and #2498

This PR uses the GUI from #2399 during the binder launch to show the current step (we can break a binder launch down into 5 steps), and we also relay the binder logs. The logs don't contain anything useful to the user, but they give a true sense of progress. (Rather than a fake loading bar 😇)

image

I used the backend_launch_phase for the subtasks of the backend launch, and I capture the JSON logs from the streaming mybinder.org API as logs in the little terminal, similar to #2498

@fonsp fonsp added frontend Concerning the HTML editor online deployment About deploying to binder, heroku, self-hosted labels Apr 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="binder-status-tab")
julia> using Pluto

@fonsp fonsp merged commit 5a30990 into main Apr 10, 2023
3 checks passed
@fonsp fonsp deleted the binder-status-tab branch April 10, 2023 14:55
@fonsp
Copy link
Owner Author

fonsp commented Apr 10, 2023

Here is a full binder launch, video file is a bit broken

cca52e1d-c1a0-4af6-b0fc-45dd979cd894.mp4

@fonsp
Copy link
Owner Author

fonsp commented Apr 10, 2023

@pankgeorg Tthis feature should already work on JH if you set the backend_launch_phase during the boot (like the local and binder backends do).

Like the binder backend, it might be nice to include the logs if they are easily available to the frontend, use https://github.com/fonsp/Pluto.jl/pull/2523/files#diff-c0a453bced0e2ce81412403f646a1e2bbfd19300fab615ce77b039a417c82dceR109-R113 to set the value of the terminal. You could also use this to print something like

Launching a 4-core 8GB computer on thisandthat account. Go to asdf.com/asdf to see all your job launches!

@fonsp
Copy link
Owner Author

fonsp commented Apr 10, 2023

Updated PR description

@fonsp fonsp added the publishing Notebooks as static documents on the web label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Concerning the HTML editor online deployment About deploying to binder, heroku, self-hosted publishing Notebooks as static documents on the web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant