-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlap removal improvements. #1485
Conversation
…y for consolidating duplicate and near-duplicate intersections.
And, yes, I know that there are still reported errors with needed versus unneeded segments, but the end product seems to be correct following this fix. I plan to deal with the unneeded segment issue once the main issue has been conclusively resolved. |
Can somebody look at the diff for me? @jtanx? |
I'm on holiday ;) Just a quick one though -
|
BTW, why would one want to disable relational geom? |
I'm always cautious when changing a data structure, particularly since Fontforge has a few that get casted to other subset or superset data structures. I also want to check before the final merge that the relational geometry actually fixes something. (I did a lot of things.) |
My testing confirms that the overlap remover fails to find matching t-values in certain cases when the relational geometry is absent, so it does indeed fix something. I'm leaving the macro conditionals for now in case we run into possibly related problems (either geometric or memory-related). |
And I'm inclined to leave the output verbosity flag out of the configure script since it's only particularly useful to somebody who is working on splineoverlap.c anyway. |
By the way, I did check output from rmo-we.sfd, and, even with the errors about needed and unneeded segments and exits from intersections, the final paths are complete and closed. |
Overlap removal improvements.
Attempt a fix for the overlap removal problems by adding functionality for consolidating duplicate and near-duplicate intersections.
This addresses #402, #473, #488, #496, and #729.
Output is extremely verbose right now. I plan to disable most of that before merging.
Due to the large structural changes in the overlap removal functionality, I would strongly encourage anybody who uses it to test the branch overlap_exploration_2 extensively and to report back to me in the next week on any problems.