Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Generation: When overwriting UFO, save fails #2424

Closed
enathu opened this issue Jul 13, 2015 · 4 comments
Closed

Font Generation: When overwriting UFO, save fails #2424

enathu opened this issue Jul 13, 2015 · 4 comments

Comments

@enathu
Copy link

enathu commented Jul 13, 2015

When generating the font (File> Generate Fonts), UFO generation works fine. But, let's say I made some changes in the font and want to generate the latest UFO by overwriting the previously generated UFO in the same path. Obviously, FF says the file already exists and asks whether to replace it or not.

ff-replace

When selecting the Replace option. FF shows a dialog box with 'Save Failed'

ff-ufo-save-fail

I have tried with other font formats, but others are working fine as intended. Only the UFO generation has this issue.

I am using latest FF on Win 8.1 & I also tried with Win7 and FF having the same issue.

Is there any fix for this?

Thank you.

@enathu enathu changed the title Font Generation: When overwriting UFO, save Fails Font Generation: When overwriting UFO, save fails Jul 13, 2015
@enathu enathu changed the title Font Generation: When overwriting UFO, save fails Font Generation: when overwriting UFO, save fails Jul 13, 2015
@enathu enathu changed the title Font Generation: when overwriting UFO, save fails Font Generation: When overwriting UFO, save fails Jul 13, 2015
@jtanx
Copy link
Contributor

jtanx commented Jul 14, 2015

The offending line is here - it's a non-portable way to remove the folder given that rm doesn't exist on Windows.

jtanx added a commit to jtanx/fontforge that referenced this issue Jul 14, 2015
jtanx added a commit to jtanx/fontforge that referenced this issue Jul 14, 2015
jtanx added a commit to jtanx/fontforge that referenced this issue Jul 14, 2015
jtanx added a commit to jtanx/fontforge that referenced this issue Jul 14, 2015
@jtanx jtanx closed this as completed in 9c7c6fc Jul 17, 2015
frank-trampe added a commit that referenced this issue Jul 17, 2015
Replace `rm -rf` with more portable code. Fixes #2424.
@enathu
Copy link
Author

enathu commented Jul 17, 2015

@jtanx Thank you. :)

@jtanx
Copy link
Contributor

jtanx commented Jul 23, 2015

@enathu if you want to test it, try installing this version

@enathu
Copy link
Author

enathu commented Jul 24, 2015

@jtanx I've just tested it, and it works as intended. Thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants