Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CharView right-click menus make no sense #4679

Open
skef opened this issue Mar 26, 2021 · 4 comments
Open

CharView right-click menus make no sense #4679

skef opened this issue Mar 26, 2021 · 4 comments

Comments

@skef
Copy link
Contributor

skef commented Mar 26, 2021

Right-clicking typically involves an alternate form of selection -- you single out what you right-click on. The current CharView right-click menus reflect this by changing depending on what you click on: Clicking on "nothing" brings up one menu with a longer list of items while clicking on a point or anchor brings up a different list.

However, most of the items in the second list aren't actually sensitive to what is clicked on. Instead of acting on the point under the pointer they act on currently selected points, assuming there are such points. A few items work as expected: "Get Info ..." brings up a point info dialog for a clicked-on point and an anchor info dialog for a clicked-on anchor.

We already have the point menu to act on selected points. The items in the right-click menu should act on the clicked-on point in isolation of what other points are selected.

When you don't click near an item you mostly get a reiteration of the tool palette. None of those entries are sensitive to where you've clicked -- you just change the tool. I guess some people might scream if this were to go away but I think it should, or should be moved to a sub-menu. Each of these has both the palette and an immediate hotkey to access.

@skef
Copy link
Contributor Author

skef commented Mar 28, 2021

Related: #4298

@skef
Copy link
Contributor Author

skef commented Apr 8, 2021

See also #493

@frank-trampe
Copy link
Contributor

Would we need to change the off-curve click behavior in order to fix the on-curve click behavior?

@skef
Copy link
Contributor Author

skef commented Apr 8, 2021

It seems to me that there should be a subset of context-neutral operations that always appear in the menu and then a subset of things that change depending on what has been clicked on. Putting the whole palette as text in the top level doesn't make much sense to me but I can see having it as a submenu (presumably the same as Point -> Tools rather than what's there now).

I don't like the fact that there are right-click operations based on selection. If I select two points and click on a third thing and pick "merge" it doesn't make sense to me that the thing I clicked on isn't affected. However, if other folks don't want to remove that stuff it especially doesn't make sense for those options to change based on what you've clicked on. (If what I happen to click on doesn't change why do I have to click on something to get the option?)

I suppose the compromise position is to move that stuff into another submenu (not necessarily called "Change Selected" but having that meaning) and leave the rest of the top-level for context dependent operations like Get Info..., Delete, and so forth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants