Plug a few memory leaks

[adrientetar]

…and fix indent along the way.

Diff without whitespace

r? @JoesCat

[adrientetar]

By the way we should run GNU Indent through the entire codebase because right now it's kind of a pain to work with existing code.

[davelab6]

On 11 July 2014 08:53, Adrien Tétar notifications@github.com wrote:

By the way we should run GNU Indent through the entire codebase because
right it's kind of a pain to work with existing code.

There's been some protest against that as it would lose git blame but
perhaps the tradeoff is worthwhile :)

[adrientetar]

There's been some protest against that as it would lose git blame but perhaps the tradeoff is worthwhile :)

You can ignore whitespace change in blame with the -w switch. But Indent would also change a bit the coding style (i.e., get rid of returns with parenthesis).

[JoesCat]

@JoesCat You can merge this Pull Request by running:

I think I'll leave this one to you. The credit is all yours.

Viewing the large number of edits, I'm guessing you're finding the scan both interesting and useful. ;-)

[adrientetar]

I'm guessing you're finding the scan both interesting and useful. ;-)

There's also a lot of overruns and memory corruptions listed there, like 30 of them or so... it's real bad.

[davelab6]

BTW Frank Trampe has requested that all pull requests be actively reviewed
by at least one other developer, and has volunteered to do that :)

I've updated the CONTRIBUTING.md file to make this clearer:

6445fd0#diff-6a3371457528722a734f3c51d9238c13R30

[adrientetar]

Good to know.

[frank-trampe]

I have reviewed the now-merged changes, and I find them entirely to my liking.