Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defects from the groups merge. #1777

Merged
merged 3 commits into from Oct 8, 2014
Merged

Conversation

frank-trampe
Copy link
Contributor

This addresses some issues from #1760 that Coverity reported.

@frank-trampe
Copy link
Contributor Author

@tshinnic, take a look.

@adrientetar
Copy link
Member

lgtm

@tshinnic
Copy link
Contributor

tshinnic commented Oct 7, 2014

Looks good to me too. Whoa, wait. What about lines 855 and 861? Same pattern as 838 and 844.

if (kc->firsts_names[tmppos] != NULL) { free(kc->firsts_names); kc->firsts_names = NULL; }


if (kc->seconds_names[tmppos] != NULL) { free(kc->seconds_names); kc->seconds_names = NULL; }

@frank-trampe
Copy link
Contributor Author

Thanks for pointing that out. I have fixed that as well.

If there's anything else, speak now or forever hold your peace.

frank-trampe added a commit that referenced this pull request Oct 8, 2014
@frank-trampe frank-trampe merged commit df39e9f into master Oct 8, 2014
@adrientetar adrientetar deleted the coverity_fixes_20141007_1 branch October 18, 2014 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants