Copyrights concerning Issue 2643 and Issue 2732 #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think line 12 in |
|
Thanks @McSinyx, you're absolutely right. |
| Copyright: 2007 George Williams | ||
| bezctx_ff.c - Provide a gateway into FontForge with added modification. | ||
| Contributions: Yuri Chornoivan, Jonathan Hanna, Joe Da Silva, Reuben Thomas, | ||
| Franke-Trampe |
There was a problem hiding this comment.
On July 19, 2016 02:42:12 PM Frank Trampe wrote:
Name is wrong.
Sorry about that, should have double checked - my error.
Debian lint highlighted some copyright questions. bezctx_ps.c from spiro-01 is GPL-2+ Patches and mods below (approx) 10 lines are listed as contributions.
Original bezctx_ps.h file is uncommented but is wrapped in GPL-2+ package. Adding authors is almost 50% of file contents, but it resolves issue 2643.
Optimized versions using lookup tables exist in several text books, especially when demonstrating hardware, CPUs, and C/assembler code.
George probably didn't want to copyright name to the file, or forgot to add it, but it's basically data files holding text information - which can then be used to make a SIL open source license. This patch resolves issue 2643 about author and file licence missing when run through debian lint.
…e#2643 Debian Lint highlighted some copyright questions concerning this file. Since it's a "generated" file (created by another program), adding a copyright notice might appear a little odd and maybe not be worth the extra effort (when you come from a generation of programmers where computers had very little memory or drive storage space, so you had to put "extra" effort to save memory/storage space). Since the project was BSD-3-clause in 2001, seems logical to imply same. Patches and mods below (approx) 10 lines are listed as contributions.
…orge#2643 Debian Lint highlighted some copyright questions concerning these files. Since they're "generated" files (created by another program), adding a copyright notice might appear a little odd and maybe not be worth the extra effort (when you come from a generation of programmers where computers had very little memory or drive storage space, so you had to put "extra" effort to save memory/storage space). Since the project was BSD-3-clause in 2001, seems logical to imply same. Patches and mods below (approx) 10 lines are listed as contributions.
|
will continue further...later... |
Omnikron13
pushed a commit
to Omnikron13/fontforge
that referenced
this pull request
May 31, 2022
* bezctx_ff.c file based on bezctx_ps.c Debian lint highlighted some copyright questions. bezctx_ps.c from spiro-01 is GPL-2+ Patches and mods below (approx) 10 lines are listed as contributions. * bezctx_ff.h file based on bezctx_ps.h Original bezctx_ps.h file is uncommented but is wrapped in GPL-2+ package. Adding authors is almost 50% of file contents, but it resolves issue 2643. * crctab.c is practically public domain Optimized versions using lookup tables exist in several text books, especially when demonstrating hardware, CPUs, and C/assembler code. * ofl.c and ofl.h created 2007-03-12 George probably didn't want to copyright name to the file, or forgot to add it, but it's basically data files holding text information - which can then be used to make a SIL open source license. This patch resolves issue 2643 about author and file licence missing when run through debian lint. * ArabicForms.c created in 2001 - call it BSD-3-clause - issue fontforge#2643 Debian Lint highlighted some copyright questions concerning this file. Since it's a "generated" file (created by another program), adding a copyright notice might appear a little odd and maybe not be worth the extra effort (when you come from a generation of programmers where computers had very little memory or drive storage space, so you had to put "extra" effort to save memory/storage space). Since the project was BSD-3-clause in 2001, seems logical to imply same. Patches and mods below (approx) 10 lines are listed as contributions. * utype.c, utype.h created in 2001 - call it BSD-3-clause - issue fontforge#2643 Debian Lint highlighted some copyright questions concerning these files. Since they're "generated" files (created by another program), adding a copyright notice might appear a little odd and maybe not be worth the extra effort (when you come from a generation of programmers where computers had very little memory or drive storage space, so you had to put "extra" effort to save memory/storage space). Since the project was BSD-3-clause in 2001, seems logical to imply same. Patches and mods below (approx) 10 lines are listed as contributions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to "help" resolve issue #2643 so that issue #2732 can proceed.
Basically a lot of reading, plus implying/adding authors who didn't add their names to the credits, and hopefully acknowledged as "okay" by the authors themselves (preferred they did it, but, well...).