Remove empty static function SCSetReasonableLBearing #2972
Conversation
|
There is clearly something wrong here, and destroying the evidence does not help us to find it. @davelab6, do you know who/what Panov is? |
gioele
force-pushed
the
remove-scsetreasonablelbearing
branch
from
d261dda
to
bc2b7b7
Compare
|
@frank-trampe this looks good to merge to me. Pavov is a long-time FF contributor who guided GWW for many years. https://www.google.co.uk/search?q=Andrey%20V.%20Panov |
| RefChar *ref; | ||
| real transform[6]; | ||
|
|
||
| /* Hmm. Panov doesn't think this should happen */ |
There was a problem hiding this comment.
@avpanov, take a look if you don't mind. George stubbed this function (which moves a glyph's left bearing to accommodate a protruding accent) because of you. Was it broken, or was it just being misused (called in cases when the bearing out to remain the same and the accent outside)?
This function has been made empty in practice (return on the first line of code) in commit 907c959 (2008). Coverity-ID: 1082680
gioele
force-pushed
the
remove-scsetreasonablelbearing
branch
from
bc2b7b7
to
196d9b1
Compare
|
This is unlikely to ever be merged, and has been explicitly rejected. Three years with no activity—time to close this out, but if there is interest in renewing this request it can easily be reopened. |
This function has been made empty in practice (return on the first line
of code) in commit 907c959 (2008).
Coverity-ID: 1082680