Add libuninameslist Names2 support #3290

JoesCat · 2018-05-16T09:20:41Z

Add native scripting and python access to libuninameslist >= ver10.9 Names2 functions

JoesCat · 2018-05-18T05:06:48Z

Hi @jtanx, @frank-trampe,
This is getting pretty close to a squash-n-merge once the python part is checked-out.
At the moment I don't have python dev loaded, but I noted that enabling it in configure failed to stop configure, so, in summary, the python part of configure needs checking first before I complete this.
If you have python dev package installed and want to give this a whirl, you can try at the commandline:
fontforge -lang=py script tests/test1090.py
it should perform similarly to
fontforge script tests/test131.pe

jtanx · 2018-05-18T09:24:23Z

.travis.yml

@@ -83,15 +83,17 @@ install:
        wget 'https://github.com/zeromq/zeromq4-1/releases/download/v4.1.5/zeromq-4.1.5.tar.gz' -O - |tar -zxf -
        wget 'https://github.com/zeromq/czmq/releases/download/v3.0.2/czmq-3.0.2.tar.gz' -O - |tar -zxf -
        wget 'https://github.com/fontforge/libspiro/releases/download/0.5.20150702/libspiro-0.5.20150702.tar.gz' -O - | tar -zxf -
-        wget 'https://github.com/fontforge/libuninameslist/releases/download/20160701/libuninameslist-20160701.tar.gz' -O - | tar -zxf -
+        # wget 'https://github.com/fontforge/libuninameslist/releases/download/20160701/libuninameslist-20160701.tar.gz' -O - | tar -zxf -


Just remove this please

Sounds good. Will upgrade.

jtanx · 2018-05-18T09:24:39Z

.travis.yml

        wget 'https://bitbucket.org/sortsmill/libunicodenames/downloads/libunicodenames-1.1.0_beta1.tar.xz' -O - | tar -Jxf -
        wget --tries 1 "http://download.savannah.gnu.org/releases/freetype/freetype-$FTVER.tar.gz" || \
          wget "https://sourceforge.net/projects/freetype/files/freetype2/$SFFTVER/freetype-$FTVER.tar.gz"

        pushd zeromq-4.1.5 && ./configure --prefix=$DEPSPREFIX && make && make install && popd
        pushd czmq-3.0.2 && CFLAGS="-Wno-format-truncation" ./configure --prefix=$DEPSPREFIX && make && make install && popd
        pushd libspiro-0.5.20150702 && ./configure --prefix=$DEPSPREFIX && make && make install && popd
-        pushd libuninameslist-20160701 && ./configure --prefix=$DEPSPREFIX && make && make install && popd
+        # pushd libuninameslist-20160701 && ./configure --prefix=$DEPSPREFIX && make && make install && popd


ditto - removed on squash-n-merge

jtanx · 2018-05-18T09:31:07Z

fontforge/python.c

+    if ( !PyArg_ParseTuple(args,"|i",&val) )
+	return( NULL );
+    if ( (temp=unicode_name2FrmTab(val))==NULL ) {
+	temp=malloc(1*sizeof(char)); *temp='\0';


Not a big fan of this. Surely you could just

return Py_BuildValue("s", "");

Nice replacement. There's a lot of places to replace stuff like this in python.c.

jtanx · 2018-05-18T09:34:17Z

gutils/unicodelibinfo.c

@@ -133,6 +140,7 @@ char *unicode_name(int32 unienc) {
     * revisit later.
     */
    if( ( unienc >= 0xAC00 && unienc <= 0xD7A3 ) && ( name_data == NULL ) ) {
+	/* replaced code below to reduce library dependencies


Can we please not do this, we already are using xasprintf so just use it.

I'm ok with it in the executables, since you need it for the GUI anyways, but if we have an opportunity to reduce dependencies in the libraries, they can be a little more portable.
I'd like to reduce dependencies on the nox if it can be done.

This code depends on xasprintf, which comes from gnulib, and is required whether or not you build with the gui.

Even if you wanted to avoid that dependency, the way you have rewritten it is not good. Instead of adding yet more magic arrays, with memcpys with magic indexing (which is hard for me and others reading this to verify that it's correct), you could have used some form of malloc+sprintf, or asprintf, instead of making it this unreadable and relying on yet more magic arrays

Anyway, just revert it back to how it was before, it compiled fine with or without the gui.

Even if you wanted to avoid that dependency, the way you have rewritten it is not good.

...would disagree. lengths pre-computed at compile. 1 alloc. 1 branch. more portable.

jtanx · 2018-05-18T09:39:28Z

tests/test1010.py

+import sys, fontforge
+
+cnt = UnicodeBlockCountFromLib()
+if ( cnt < 1 ):


This is python, not C, remove the brackets.

Didn't want it to be confused as a variable :-)
...but it appears to be common:
https://stackoverflow.com/questions/19747371/python-exit-commands-why-so-many-and-when-should-each-be-used
...even here, there is an example where you need to say quit() exit(), not quit or exit.

Functions have nothing to do with if statements. Having brackets where they are unnecessary in such statements is un-pythonic. Just remove them.

jtanx · 2018-05-18T09:40:41Z

tests/test1010.py

+u1 = fontforge.UnicodeNames2NxtUniFromLib(1)
+u2 = fontforge.UnicodeNames2NxtUniFromLib(2)
+print("Sample of internal table has ",u0,", ",u1,", ",u2," as the first 3 unicode values.")
+if ( u0 < 0 || u1 < 1 || u2 < 2 ):


or, not ||. Did you run this locally?

Still need to get python dev loaded. This can get removed in a squash-merge.

jtanx · 2018-05-18T09:42:45Z

If you're going to add this for python, then please get a python build working and test it locally before continuing.

JoesCat · 2018-05-22T23:13:35Z

ready to squash-n-merge.

frank-trampe · 2018-05-24T17:49:16Z

Okay. Do it.

JoesCat · 2018-05-24T18:14:34Z

Hi @frank-trampe - I was about to head-out-the-door.
I see @khaledhosny patch getting merged now - so it's going to still be checking before I'm out.
If this and the others look ok to you, please go ahead and merge - these will take time to get the check (vs the X).

* Add libuninameslist Names2 support * Add libuninameslist Names2 support * Add libuninameslist Names2 support * Add libuninameslist Names2 support * Add libuninameslist Names2 support * Add libuninameslist Names2 support

Add libuninameslist Names2 support

bca9bdb

JoesCat mentioned this pull request May 16, 2018

Add ./configure --enable-fontforge-extras #3286

Merged

JoesCat added 4 commits May 17, 2018 14:00

Add libuninameslist Names2 support

72fc906

Add libuninameslist Names2 support

c288d64

Add libuninameslist Names2 support

f5ac471

Add libuninameslist Names2 support

e7418c1

JoesCat requested review from jtanx and frank-trampe May 18, 2018 05:06

jtanx reviewed May 18, 2018

View reviewed changes

Add libuninameslist Names2 support

b5ddeac

JoesCat merged commit 1d9fb33 into fontforge:master May 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add libuninameslist Names2 support #3290

Add libuninameslist Names2 support #3290

JoesCat commented May 16, 2018 •

edited

JoesCat commented May 18, 2018

jtanx May 18, 2018

JoesCat May 18, 2018

jtanx May 18, 2018

JoesCat May 18, 2018

jtanx May 18, 2018

JoesCat May 18, 2018

jtanx May 18, 2018 •

edited

JoesCat May 18, 2018

jtanx May 18, 2018

JoesCat May 22, 2018

jtanx May 18, 2018

JoesCat May 18, 2018

jtanx May 18, 2018

jtanx May 18, 2018

JoesCat May 18, 2018

jtanx commented May 18, 2018

JoesCat commented May 22, 2018

frank-trampe commented May 24, 2018

JoesCat commented May 24, 2018

Add libuninameslist Names2 support #3290

Add libuninameslist Names2 support #3290

Conversation

JoesCat commented May 16, 2018 • edited

JoesCat commented May 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtanx May 18, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtanx commented May 18, 2018

JoesCat commented May 22, 2018

frank-trampe commented May 24, 2018

JoesCat commented May 24, 2018

JoesCat commented May 16, 2018 •

edited

jtanx May 18, 2018 •

edited