Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmenu.c: prevent the menu key from creating a menu if one is already present #4463

Merged
merged 1 commit into from Nov 6, 2020

Conversation

jtanx
Copy link
Contributor

@jtanx jtanx commented Oct 7, 2020

Fixes #4462

Type of change

  • Bug fix

@frank-trampe
Copy link
Contributor

GMenuCreatePopupMenuWithName, which ultimately sets most_recent_popup_menu, is called in fontview.c and cvpalettes.c and maybe other places. Do we need to guard those calls too?

@jtanx
Copy link
Contributor Author

jtanx commented Nov 4, 2020

Those should be fine since they're only called in response to right clicks, and the mouse is grabbed while a menu is active. But there's no harm in adding another check there so I've added it.

@jtanx
Copy link
Contributor Author

jtanx commented Nov 4, 2020

Actually change of mind, I'll just keep the original fix.

@frank-trampe frank-trampe merged commit 8365f6f into fontforge:master Nov 6, 2020
Omnikron13 pushed a commit to Omnikron13/fontforge that referenced this pull request May 31, 2022
gmenu.c: prevent the menu key from creating a menu if one is already present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue about right-click button on windows OS
2 participants