Stop adding Reserved Font Names (RFNs) to OFL #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FontForge has no way to figure out whether it's making a legally possible request when adding a reserved font name, and a minority of OFL license users even use RFN's in the first place. Close fontforge#4434
ctrlcctrlv
commented
Dec 13, 2020
| "Copyright (c) %1$d, %2$s (<URL|email>),", /* <Date> <Copyright Holder> */ | ||
| "with Reserved Font Name %s.", /* <Font Family Name> */ | ||
| "", | ||
| "This Font Software is licensed under the SIL Open Font License, Version 1.1.", |
|
I'm not qualified to provide a second set of eyes here. @davelab6, please advise. |
|
@frank-trampe I based my changes on Dave's comment here: #4434 (comment). Unless I missed something I followed them to the letter. |
|
Ah, okay. Let's merge this. |
frank-trampe
approved these changes
Jan 1, 2021
Closed
Omnikron13
pushed a commit
to Omnikron13/fontforge
that referenced
this pull request
May 31, 2022
Stop adding Reserved Font Names (RFNs) to OFL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FontForge has no way to figure out whether it's making a legally possible request when adding an RFN, and a minority of OFL license users even use RFN's in the first place.
Important to note: This will not change anyone's fonts, only new fonts! It's only triggered when "Add OFL" is pressed, as in, it's a convenience feature where we try to do the sane thing for most font authors who want to free their font.
Close #4434