Allow 0-len mult subs in UI, feature files (GSUB) #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skef
reviewed
Feb 6, 2021
ctrlcctrlv
force-pushed
the
multsub0len
branch
from
7c43ead
to
f786db0
Compare
ctrlcctrlv
force-pushed
the
multsub0len
branch
from
f786db0
to
30b14e5
Compare
|
This looks fine to me relative to the caveats about error reporting. I'm going to put off approving for a day or two in case @frank-trampe or anyone else has a contrary opinion. |
skef
approved these changes
Feb 10, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows glyph deletion in OpenType Layout.
Cf. MicrosoftDocs/typography-issues#673, fonttools/fonttools#2170, adobe-type-tools/afdko#1251
Close #4618
FontForge already supported this implicitly: reading an OpenType font which uses this mechanism works, as does writing it back. Adding one in the UI was broken, as were feature files in both directions. This PR fixes that.
Type of change