Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix painting behaviour of the ruler linger window and layer change dialog #5163

Merged
merged 2 commits into from Dec 30, 2022

Conversation

jtanx
Copy link
Contributor

@jtanx jtanx commented Dec 30, 2022

Fixes #5119

Type of change

  • Bug fix

@@ -1003,6 +1003,5 @@ return;
}
prev_rect = rect;
}
RulerLingerMove(cv); /* in case things are moving or scaling */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling this from the expose event, I call it in response to the charview doing a scroll or zoom.

Copy link
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skef
Copy link
Contributor

skef commented Dec 30, 2022

This second commit looks OK too, given that the timer is set just before.

@jtanx jtanx merged commit eb78d6d into fontforge:master Dec 30, 2022
@jtanx jtanx deleted the gg branch December 30, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GGDKDraw assertion failure when using ruler
2 participants