Set window type dialog for dialogs and transient windows #5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example screenshots? |
|
I don't know how to show this in a screenshot so I've recorded a video: https://youtu.be/embWmXLwOXk |
|
Tested in Gnome, KDE and windows: In Gnome the Font Info dialog is non-modal, but is kept above all other windows, which is inconsistent with other window managers and probaly undesired. On project: On system: |
|
In Windows the Font Info dialog ceased to participate in tiling arrangement, which is the desired behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now dialogs and transient windows have a correct window type so a window manager can better understand how to display them. (In my particular case, dwm checks window type and displays dialogs in floating mode)