Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that axis min/max values are in line with the spec #2264

Closed
mjlagattuta opened this issue Dec 10, 2018 · 0 comments
Closed

Check that axis min/max values are in line with the spec #2264

mjlagattuta opened this issue Dec 10, 2018 · 0 comments
Assignees
Milestone

Comments

@mjlagattuta
Copy link
Contributor

Observed behaviour

While working on Hepta Slab, my lightest instance was nan-canonical "Hairline" and sat at 0 on the weight axis in order to maintain even steps of 100. The OT spec itself says the range for this axis is 1-1000. The font builds fine even though 0 is outside the range, and there were no fvar warns in fontbakery.

When testing the font on Windows Word this was an issue since the Hairline instance failed to properly render, and was actually thicker then the Thin instance. It rendered as expected once the minimum was set to 1 in accordance with the spec.

Expected behaviour

I would expect FontBakery to note when axis min/maxes or instance values fall outside ranges noted in the spec.

Resources and exact process needed to replicate

Hepta with min of 1 @ commit 01ca19d
Hepta with min of 0 @ commit bb93812

@felipesanches felipesanches added this to the 0.6.6 milestone Dec 12, 2018
@felipesanches felipesanches self-assigned this Dec 12, 2018
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 13, 2018
Weight axis coordinate must be within spec range of 1 to 1000 on all instances.
(issue fonttools#2264)
felipesanches added a commit that referenced this issue Dec 13, 2018
Weight axis coordinate must be within spec range of 1 to 1000 on all instances.
(issue #2264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants