New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
varLib.instancer --update-name-table not updating nameID 25 with Roman/italic #2336
Comments
I report here the discussion from the chat: Rosa: We have more and more fonts which gather the Roman and Italic in the same source file, and they need to be separated in 2 variable fonts before getting onboarded (without duplicating sources would be the best). We have been using the fabulous varLib.instancer, but it doesn't get the name ID25 as the builder does. The question is: shall fonttools fix the name tables, or should we make a post-process script, or can it be integrated to the builder in some way? Dave: it should be done in fonttools… what are the differing opinions? Rosa: googlefonts/gftools#297 |
Agree on the FontTools part. Hoping the solution will deal with a Slant axis as well as an Italic axis. |
AH GF eng said they would handle the slant axis as any other axes (not like weight and italic) |
Apologies for my late response. I had forgotten why we never updated this record but it occurred to me last night why. In the MS spec, it says:
https://docs.microsoft.com/en-us/typography/opentype/spec/name#name-ids Both myself and Cosimo believe that this name record is only used for the purpose mentioned above. Currently at Google Fonts, we believe that nameID 25 needs to be unique for each font which makes up a VF family e.g for a family which consists of a Roman and an Italic font, we would expect the following for nameID 25: Roman VF: Unfortunately, the above records will generate horrible postscript names when using the Adobe PS Name Generation heuristic which we do use e.g: Instantiated Roman postscript name: If we don't update name record 25 which is the current behaviour, we get: Roman VF postscript name: I hope the above makes sense. More than happy to explain further. |
The requirement for unique prefix is a workaround for an Adobe CC bug. I don’t think it is appropriate to hard-code such work arounds in FontTools. If GF need this work around, it should be in a GF-specific tool. |
It seems to me odd that adobe didn't contribute this to the MSOT/MOFF
specs. I'll ask Adobe why.
Given I believe there are other things we do in fonttools that are
practical to ensure the results work widely, I'm not sure it's so
inappropriate.
|
Here's a reference from @punchcutter at |
Some things never change... |
When separating italic and roman, nameID25 remains
FontName
instead ofFontNameRoman
/FontNameItalic
. Although opinion are differing if it should be done by default or not. Since it is required on GF end for new VF, it may be implemented as an option?The text was updated successfully, but these errors were encountered: