[gftools-packager] Urbanist: Version 1.250 added #3431

coreyhu · 2021-05-20T01:49:52Z

Urbanist Version 1.250 taken from the upstream repo https://github.com/coreyhu/Urbanist at commit coreyhu/Urbanist@848dc17.

* Urbanist Version 1.250 taken from the upstream repo https://github.com/coreyhu/Urbanist at commit coreyhu/Urbanist@848dc17.

coreyhu · 2021-05-20T01:54:30Z

Hi @RosaWagner this is a followup to #3418 which is now closed. There've been some updates and the fontbakery checks on the static files should now all pass. The variable file uses an ital axis so it only fails the unsupported-ital check.

Apologies, are you able to re-add it to the pipeline?

davelab6 · 2021-05-20T15:01:30Z

@coreyhu wow this is amazing work!! I've approved this for @RosaWagner to merge once any issues she finds are resolved

m4rc1e · 2021-05-24T12:05:53Z

LGTM. Let's get this into production. Thanks @coreyhu!

m4rc1e · 2021-05-24T12:08:17Z

I've removed the ital axis since older versions of firefox/chrome have patchy support. We will reenable the axis once these browsers are used by less people.

coreyhu · 2021-05-24T19:11:53Z

Sounds good! Let me know if any additional changes are necessary. Will the italics still be available as static files?

RosaWagner · 2021-05-25T08:53:22Z

Wait wait wait before merging. There are still some stuff to correct, like the OFL, which is missing a part in the header. @coreyhu contact me by email to arrange a call, so I can also explain the different choices for the ital axis.

coreyhu · 2021-05-25T20:27:40Z

Thanks, the OFL header has been updated and I sent you an email to follow up. Let me know if there's any additional changes that need to be made!

coreyhu · 2021-06-01T17:56:22Z

Hi all, I made the following changes:

Updated the OFL header
Built two separate Roman and Italic VF files that can be used until the ital axis is better supported.
Repackaged with --no-source

Please let me know if any other changes are necessary

RosaWagner · 2021-06-03T11:33:45Z

Base letters (and comb accents) don't have anchors. Sorry I missed that earlier. This check is still not implemented in FB but will come.
coreyhu/Urbanist#28

RosaWagner · 2021-06-09T10:33:57Z

Fontbakery report

Fontbakery version: 0.7.37

[8] Urbanist-Italic[wght].ttf

🔥 FAIL: Checks METADATA.pb font.post_script_name matches postscript name declared on the name table.

com.google.fonts/check/metadata/nameid/post_script_name
🔥 FAIL Unmatched postscript name in font: TTF has "Urbanist-Regular" while METADATA.pb has "Urbanist-Italic". [code: mismatch]

🔥 FAIL: METADATA.pb font.full_name value matches fullname declared on the name table?

com.google.fonts/check/metadata/nameid/full_name
🔥 FAIL Unmatched fullname in font: TTF has "Urbanist Regular" while METADATA.pb has "Urbanist Italic". [code: mismatch]

🔥 FAIL: METADATA.pb font.style "italic" matches font internals?

com.google.fonts/check/metadata/italic_style
🔥 FAIL Font macStyle Italic bit is set but nameID 4 ("Urbanist Regular") is not ended with "Italic". [code: bad-fullfont-name]

🔥 FAIL: METADATA.pb font.name and font.full_name fields match the values declared on the name table?

com.google.fonts/check/metadata/nameid/family_and_full_names
🔥 FAIL METADATA.pb: Fullname "Urbanist Italic" does not match name table entry "Urbanist Regular"! [code: fullname-mismatch]

⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?

com.google.fonts/check/metadata/listed_on_gfonts
⚠ WARN Family not found via Google Fonts API. [code: not-found]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts

com.google.fonts/check/repo/vf_has_static_fonts

--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.

⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: METADATA.pb: Designer is listed with the correct name on the Google Fonts catalog of designers?

com.google.fonts/check/metadata/designer_profiles
⚠ WARN It seems that Corey Hu is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]

⚠ WARN: Are there any misaligned on-curve points?

[com.google.fonts/check/outline_alignment_miss](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/<Section: Outline Correctness Checks>.html#com.google.fonts/check/outline_alignment_miss)

--- Rationale ---
This check heuristically looks for on-curve points which are close to, but do
not sit on, significant boundary coordinates. For example, a point which has a
Y-coordinate of 1 or -1 might be a misplaced baseline point. As well as the
baseline, here we also check for points near the x-height (but only for lower
case Latin letters), cap-height, ascender and descender Y coordinates.
Not all such misaligned curve points are a mistake, and sometimes the design may
call for points in locations near the boundaries. As this check is liable to
generate significant numbers of false positives, it will pass if there are more
than 100 reported misalignments.

⚠ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
- uni1E9E: X=567.0,Y=1399.0 (should be at cap-height 1400?)
- question: X=238.0,Y=-2.0 (should be at baseline 0?)
- question: X=351.0,Y=-2.0 (should be at baseline 0?) and integral: X=-27.5,Y=2.0 (should be at baseline 0?) [code: found-misalignments]

[4] Urbanist[wght].ttf

⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?

com.google.fonts/check/metadata/listed_on_gfonts
⚠ WARN Family not found via Google Fonts API. [code: not-found]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts

com.google.fonts/check/repo/vf_has_static_fonts

--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.

⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: METADATA.pb: Designer is listed with the correct name on the Google Fonts catalog of designers?

com.google.fonts/check/metadata/designer_profiles
⚠ WARN It seems that Corey Hu is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]

⚠ WARN: Are there any misaligned on-curve points?

[com.google.fonts/check/outline_alignment_miss](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/<Section: Outline Correctness Checks>.html#com.google.fonts/check/outline_alignment_miss)

--- Rationale ---
This check heuristically looks for on-curve points which are close to, but do
not sit on, significant boundary coordinates. For example, a point which has a
Y-coordinate of 1 or -1 might be a misplaced baseline point. As well as the
baseline, here we also check for points near the x-height (but only for lower
case Latin letters), cap-height, ascender and descender Y coordinates.
Not all such misaligned curve points are a mistake, and sometimes the design may
call for points in locations near the boundaries. As this check is liable to
generate significant numbers of false positives, it will pass if there are more
than 100 reported misalignments.

⚠ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
- uni1E9E: X=567.0,Y=1399.0 (should be at cap-height 1400?)
- question: X=434.5,Y=-2.0 (should be at baseline 0?)
- question: X=547.5,Y=-2.0 (should be at baseline 0?) and integral: X=168.5,Y=2.0 (should be at baseline 0?) [code: found-misalignments]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	4	8	98	17	266	0
0%	1%	2%	25%	4%	68%	0%

Note: The following loglevels were omitted in this report:

SKIP
INFO
PASS
DEBUG

RosaWagner · 2021-06-10T17:03:43Z

Side note: for this PR we are waiting for fonttools to fix the problem with the name ID25 : fonttools/fonttools#2336

coreyhu · 2021-06-11T02:18:39Z

Would there be an issue with adding a step in the build workflow to correct nameID 25 after running VarLib Instancer?

RosaWagner · 2021-06-11T05:33:25Z

You can do so :)
Internally we decided that it should be fixed by fonttools, so I am not spending time on it, but you can do. Please inspect Texturina’s names table. Someone else will have to check it, cause I am on holidays for 3 weeks from today :)

coreyhu · 2021-06-14T05:56:58Z

Enjoy the break! Meanwhile, nameID 25 should now be updated. Is someone able to check it out? Thanks in advance!

coreyhu · 2021-07-11T00:35:40Z

Finally got around to writing the postprocessing script for updating the name table. I believe this should match Texturina

RosaWagner · 2021-07-15T10:00:23Z

Author corrected the name ID 25 with a script after slicing Roman/Italic with Fonttools, so I doubled check in Indesign and it works fine :)

LGTM

Fontbakery report

Fontbakery version: 0.7.37

[1] Family checks

🔥 FAIL: Do we have the latest version of FontBakery installed?

com.google.fonts/check/fontbakery_version
🔥 FAIL Current Font Bakery version is 0.7.37, while a newer 0.7.38 is already available. Please upgrade it with 'pip install -U fontbakery'

[1] Urbanist-Italic[wght].ttf

⚠ WARN: Are there any misaligned on-curve points?

[com.google.fonts/check/outline_alignment_miss](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/<Section: Outline Correctness Checks>.html#com.google.fonts/check/outline_alignment_miss)

--- Rationale ---
This check heuristically looks for on-curve points which are close to, but do
not sit on, significant boundary coordinates. For example, a point which has a
Y-coordinate of 1 or -1 might be a misplaced baseline point. As well as the
baseline, here we also check for points near the x-height (but only for lower
case Latin letters), cap-height, ascender and descender Y coordinates.
Not all such misaligned curve points are a mistake, and sometimes the design may
call for points in locations near the boundaries. As this check is liable to
generate significant numbers of false positives, it will pass if there are more
than 100 reported misalignments.

⚠ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
- uni1E9E: X=567.0,Y=1399.0 (should be at cap-height 1400?)
- question: X=238.0,Y=-2.0 (should be at baseline 0?)
- question: X=351.0,Y=-2.0 (should be at baseline 0?) and integral: X=-27.5,Y=2.0 (should be at baseline 0?) [code: found-misalignments]

[1] Urbanist[wght].ttf

⚠ WARN: Are there any misaligned on-curve points?

[com.google.fonts/check/outline_alignment_miss](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/<Section: Outline Correctness Checks>.html#com.google.fonts/check/outline_alignment_miss)

--- Rationale ---
This check heuristically looks for on-curve points which are close to, but do
not sit on, significant boundary coordinates. For example, a point which has a
Y-coordinate of 1 or -1 might be a misplaced baseline point. As well as the
baseline, here we also check for points near the x-height (but only for lower
case Latin letters), cap-height, ascender and descender Y coordinates.
Not all such misaligned curve points are a mistake, and sometimes the design may
call for points in locations near the boundaries. As this check is liable to
generate significant numbers of false positives, it will pass if there are more
than 100 reported misalignments.

⚠ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
- uni1E9E: X=567.0,Y=1399.0 (should be at cap-height 1400?)
- question: X=434.5,Y=-2.0 (should be at baseline 0?)
- question: X=547.5,Y=-2.0 (should be at baseline 0?) and integral: X=168.5,Y=2.0 (should be at baseline 0?) [code: found-misalignments]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	1	2	196	15	179	0
0%	0%	1%	50%	4%	46%	0%

Note: The following loglevels were omitted in this report:

SKIP
INFO
PASS
DEBUG

Urbanist_QA.zip

[gftools-packager] Urbanist: Version 1.250 added

3ac84cd

* Urbanist Version 1.250 taken from the upstream repo https://github.com/coreyhu/Urbanist at commit coreyhu/Urbanist@848dc17.

RosaWagner added -- Needs manager's opinion from upper level I New Font labels May 20, 2021

davelab6 removed the -- Needs manager's opinion from upper level label May 20, 2021

davelab6 requested a review from RosaWagner May 20, 2021 15:01

RosaWagner added the - Ready for Review label May 20, 2021

Update DESCRIPTION.en_us.html

1166149

urbanist: remove ital axis

d2706a5

RosaWagner added -- Needs Upstream Resolution Upstream fix required before moving forward and removed - Ready for Review labels May 25, 2021

Update OFL Header

42a63fd

repackage separated Roman and Italic VFs with --no-source

f01e078

Update to Urbanist 1.251

4a9aa94

RosaWagner mentioned this pull request Jun 3, 2021

FAIL if no mark_to_mark feature fonttools/fontbakery#3322

Open

RosaWagner linked an issue Jun 3, 2021 that may be closed by this pull request

Add the Urbanist Family #2326

Closed

8 tasks

Use anchors for standard alignment

ab45d26

RosaWagner added - Ready for Review and removed -- Needs Upstream Resolution Upstream fix required before moving forward labels Jun 4, 2021

RosaWagner added 3 commits June 4, 2021 16:24

Urbanist: description updated

f69b0b3

Urbanist : remove one linebreak in OFL.txt

4293b51

Urbanist: updated upstream.yaml

d70fbcc

coreyhu added 2 commits June 4, 2021 07:48

Minor alignment fixes

09dc9dc

Remove statics

db4b950

RosaWagner added - In Progress and removed - Ready for Review labels Jun 9, 2021

coreyhu added 2 commits June 13, 2021 22:34

Fix name table in build script

9ac8586

Fix postscript name

5c3a492

coreyhu added 2 commits July 10, 2021 17:18

fix instance postscript names

0fa107a

fix OFL for license check

ffe3ede

RosaWagner merged commit fe7c8ea into google:main Jul 15, 2021

RosaWagner added --- to_sandbox and removed - In Progress labels Jul 15, 2021

RosaWagner added --- to_production and removed --- to_sandbox labels Aug 12, 2021

RosaWagner added --- Live Font is visible on API and removed --- to_production labels Aug 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[gftools-packager] Urbanist: Version 1.250 added #3431

[gftools-packager] Urbanist: Version 1.250 added #3431

coreyhu commented May 20, 2021

coreyhu commented May 20, 2021

davelab6 commented May 20, 2021

m4rc1e commented May 24, 2021

m4rc1e commented May 24, 2021

coreyhu commented May 24, 2021 •

edited

RosaWagner commented May 25, 2021

coreyhu commented May 25, 2021

coreyhu commented Jun 1, 2021

RosaWagner commented Jun 3, 2021 •

edited

RosaWagner commented Jun 9, 2021

RosaWagner commented Jun 10, 2021

coreyhu commented Jun 11, 2021

RosaWagner commented Jun 11, 2021

coreyhu commented Jun 14, 2021

coreyhu commented Jul 11, 2021

RosaWagner commented Jul 15, 2021

[gftools-packager] Urbanist: Version 1.250 added #3431

[gftools-packager] Urbanist: Version 1.250 added #3431

Conversation

coreyhu commented May 20, 2021

coreyhu commented May 20, 2021

davelab6 commented May 20, 2021

m4rc1e commented May 24, 2021

m4rc1e commented May 24, 2021

coreyhu commented May 24, 2021 • edited

RosaWagner commented May 25, 2021

coreyhu commented May 25, 2021

coreyhu commented Jun 1, 2021

RosaWagner commented Jun 3, 2021 • edited

RosaWagner commented Jun 9, 2021

Fontbakery report

Summary

RosaWagner commented Jun 10, 2021

coreyhu commented Jun 11, 2021

RosaWagner commented Jun 11, 2021

coreyhu commented Jun 14, 2021

coreyhu commented Jul 11, 2021

RosaWagner commented Jul 15, 2021

Fontbakery report

Summary

Urbanist_QA.zip

coreyhu commented May 24, 2021 •

edited

RosaWagner commented Jun 3, 2021 •

edited