Skip to content

Commit

Permalink
Remove feedback form
Browse files Browse the repository at this point in the history
  • Loading branch information
kidhab committed Nov 12, 2023
1 parent e194c68 commit bc329fe
Show file tree
Hide file tree
Showing 13 changed files with 1 addition and 129 deletions.
12 changes: 0 additions & 12 deletions app/controllers/feedback_controller.rb

This file was deleted.

15 changes: 1 addition & 14 deletions app/mailers/mailer.rb
Expand Up @@ -99,15 +99,6 @@ def negative_balance(user, transaction)
subject: I18n.t('mailer.negative_balance.subject')
end

def feedback(user, feedback)
@user = user
@feedback = feedback

mail to: feedback_recipients,
from: user,
subject: I18n.t('mailer.feedback.subject')
end

def not_enough_users_assigned(task, user)
@task = task
@user = user
Expand Down Expand Up @@ -180,8 +171,4 @@ def format_address(email, name)
address.format
end

Check failure on line 173 in app/mailers/mailer.rb

View workflow job for this annotation

GitHub Actions / test

Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.

Check failure on line 173 in app/mailers/mailer.rb

View workflow job for this annotation

GitHub Actions / test

Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.
# use the (new) feedback_recipients option, but fallback to error_recipients for backwards compatibility
def feedback_recipients
FoodsoftConfig[:notification][:feedback_recipients] || FoodsoftConfig[:notification][:error_recipients]
end
end
end

Check failure on line 174 in app/mailers/mailer.rb

View workflow job for this annotation

GitHub Actions / test

Layout/TrailingEmptyLines: Final newline missing.

Check failure on line 174 in app/mailers/mailer.rb

View workflow job for this annotation

GitHub Actions / test

Layout/TrailingEmptyLines: Final newline missing.
9 changes: 0 additions & 9 deletions app/views/feedback/new.html.haml

This file was deleted.

1 change: 0 additions & 1 deletion app/views/layouts/application.html.haml
Expand Up @@ -16,7 +16,6 @@
= link_to FoodsoftConfig[:name], FoodsoftConfig[:homepage], target: '_blank'
- if FoodsoftConfig[:help_url]
%li= link_to t('.help'), FoodsoftConfig[:help_url], target: '_blank'
%li= link_to t('.feedback.title'), new_feedback_path, title: t('.feedback.desc')
.clearfix

.navbar
Expand Down
3 changes: 0 additions & 3 deletions app/views/mailer/feedback.text.haml

This file was deleted.

2 changes: 0 additions & 2 deletions config/app_config.yml.SAMPLE
Expand Up @@ -143,8 +143,6 @@ default: &defaults
notification:
error_recipients:
- admin@foodcoop.test
feedback_recipients:
- support@foodcoop.test
sender_address: "\"Foodsoft Error\" <foodsoft@foodcoop.test>"
email_prefix: "[Foodsoft]"

Expand Down
14 changes: 0 additions & 14 deletions config/locales/de.yml
Expand Up @@ -779,14 +779,6 @@ de:
not_found:
text: Diese Seite existiert anscheinend nicht. Entschuldigung!
title: Seite nicht gefunden
feedback:
create:
notice: Das Feedback wurde erfolgreich verschickt. Vielen Dank!
new:
first_paragraph: Fehler gefunden? Vorschlag? Idee? Kritik? Wir freuen uns über jegliches Feedback.
second_paragraph: Bitte beachte, dass das Foodsoft Team nur die Software wartet. Bei Fragen zur Organisation in Deiner Foodcoop, kontaktiere besser die entsprechenden Ansprechpartner.
send: Absenden
title: Gib Feedback
finance:
balancing:
close:
Expand Down Expand Up @@ -1232,9 +1224,6 @@ de:
footer:
revision: Revision %{revision}
header:
feedback:
desc: Fehler gefunden? Vorschlag? Idee? Kritik?
title: Feedback
help: Hilfe
logout: Abmelden
ordergroup: Meine Bestellgruppe
Expand Down Expand Up @@ -1269,9 +1258,6 @@ de:
title: Neues Passwort
mailer:
dateformat: "%d. %b"
feedback:
header: "%{user} schrieb am %{date}:"
subject: Feedback zur Foodsoft
from_via_foodsoft: "%{name} via Foodsoft"
invite:
subject: Einladung in die Foodcoop
Expand Down
14 changes: 0 additions & 14 deletions config/locales/en.yml
Expand Up @@ -779,14 +779,6 @@ en:
not_found:
text: This page does not appear to exist, sorry!
title: Page not found
feedback:
create:
notice: Your feedback was sent successfully. Thanks a lot!
new:
first_paragraph: Found a bug? Suggestions? Ideas? Reviews? We are happy to hear any feedback.
second_paragraph: Please be aware that the Foodsoft Team is only responsible for the maintenance of the software. For questions regarding the organisation of your Foodcoop, please contact the appropriate contact person.
send: Send
title: Give feedback
finance:
balancing:
close:
Expand Down Expand Up @@ -1232,9 +1224,6 @@ en:
footer:
revision: revision %{revision}
header:
feedback:
desc: Found a bug? Suggestions? Ideas? Review?
title: Feedback
help: Help
logout: Logout
ordergroup: My ordergroup
Expand Down Expand Up @@ -1269,9 +1258,6 @@ en:
title: New password
mailer:
dateformat: "%d %b"
feedback:
header: "%{user} wrote at %{date}:"
subject: Feedback for Foodsoft
from_via_foodsoft: "%{name} via Foodsoft"
invite:
subject: Invitation to the Foodcoop
Expand Down
14 changes: 0 additions & 14 deletions config/locales/es.yml
Expand Up @@ -779,14 +779,6 @@ es:
not_found:
text: Esta página parece no existir. ¡Lo sentimos!
title: Página no encontrada
feedback:
create:
notice: Tus comentarios fueron enviados con éxito. ¡Muchas gracias!
new:
first_paragraph: '¿Encontraste un error? ¿Tienes sugerencias, ideas o comentarios? Nos gustaría recibir tus comentarios.'
second_paragraph: Tenga en cuenta que el equipo de Foodsoft es el único responsable del mantenimiento del software. Para preguntas relacionadas con la organización de tu Foodcoop, por favor contacta a la persona de contacto apropiada.
send: Enviar
title: Enviar comentarios
finance:
balancing:
close:
Expand Down Expand Up @@ -1232,9 +1224,6 @@ es:
footer:
revision: revisión %{revision}
header:
feedback:
desc: '¿Encontrase algún error? ¿Sugerencias? ¿Ideas?'
title: Sugerencias
help: Ayuda
logout: Salir
ordergroup: Mis grupos de pedido
Expand Down Expand Up @@ -1269,9 +1258,6 @@ es:
title: Nueva contraseña
mailer:
dateformat: "%d %b"
feedback:
header: "%{user} escribió %{date}:"
subject: Comentarios para Foodsoft
from_via_foodsoft: "%{name} vía Foodsoft"
invite:
subject: Invitación al Foodcoop
Expand Down
14 changes: 0 additions & 14 deletions config/locales/fr.yml
Expand Up @@ -493,14 +493,6 @@ fr:
general: Un problème a été rencontré.
general_again: Une erreur s'est produite. Merci de réessayer.
general_msg: 'Une erreur s''est produite: %{msg}'
feedback:
create:
notice: Ton commentaire a été transmis avec succès. Merci
new:
first_paragraph: Tu as trouvé une erreur? Tu as une proposition, une idée, une critique? Envoie un commentaire!
second_paragraph: "Petite remarque: l'équipe de Foodsoft s'occupe seulement de la maintenance du logiciel.\nPour les questions concernants l'organisation de ta boufcoop, il faut contacter les personnes concernées."
send: Transmettre
title: Laisser un commentaire
finance:
balancing:
close:
Expand Down Expand Up @@ -841,9 +833,6 @@ fr:
footer:
revision: révision %{revision}
header:
feedback:
desc: Tu as trouvé une erreur? Tu as des propositions, des idées, des critiques?
title: Retours
help: Aide
logout: Déconnexion
ordergroup: Ta cellule
Expand Down Expand Up @@ -876,9 +865,6 @@ fr:
submit: Sauvegarder le nouveau mot de passe
title: Nouveau mot de passe
mailer:
feedback:
header: "Le %{date}, %{user} a écrit:"
subject: Feedback pour Foodsoft
invite:
subject: Invitation à participer à une Bouffecoop
text: |
Expand Down
14 changes: 0 additions & 14 deletions config/locales/nl.yml
Expand Up @@ -779,14 +779,6 @@ nl:
not_found:
text: Deze pagina bestaat niet, sorry!
title: Pagina niet gevonden
feedback:
create:
notice: Bericht verstuurd. Vriendelijk bedankt!
new:
first_paragraph: Probleem gevonden? Voorstel? Idee? Verbeterpunt? We horen graag je feedback.
second_paragraph: Dit bericht wordt verstuurd naar de ontwikkelaars van de bestelsoftware. Voor vragen over de organisatie van je foodcoop kun je je tot de lokale organisatie wenden.
send: Verzenden
title: Feedback geven
finance:
balancing:
close:
Expand Down Expand Up @@ -1232,9 +1224,6 @@ nl:
footer:
revision: revisie %{revision}
header:
feedback:
desc: Foutje gevonden? Suggesties? Ideeën? Commentaar?
title: Feedback
help: Help
logout: Uitloggen
ordergroup: Mijn huishouden
Expand Down Expand Up @@ -1269,9 +1258,6 @@ nl:
title: Nieuw wachtwoord
mailer:
dateformat: "%d %b"
feedback:
header: "%{user} schreef op %{date}:"
subject: Feedback van %{email}
from_via_foodsoft: "%{name} via Foodsoft"
invite:
subject: Uitnodiging voor de foodcoop
Expand Down
14 changes: 0 additions & 14 deletions config/locales/tr.yml
Expand Up @@ -778,14 +778,6 @@ tr:
not_found:
text: Bu sayfa mevcut değil, üzgünüz!
title: Sayfa bulunamadı
feedback:
create:
notice: Geri bildiriminiz başarıyla gönderildi. Teşekkür ederiz!
new:
first_paragraph: Bir hata buldunuz mu? Önerileriniz mi var? Fikirleriniz mi? Geri bildirimlerinizi duymaktan mutluluk duyarız.
second_paragraph: Lütfen unutmayın, Foodsoft ekibi yalnızca yazılımın bakımından sorumludur. Foodcoop'unuzun organizasyonuyla ilgili sorularınız için uygun kişiye başvurmanız gerekmektedir.
send: Gönder
title: Geri Bildirim Ver
finance:
balancing:
close:
Expand Down Expand Up @@ -1230,9 +1222,6 @@ tr:
footer:
revision: revizyon %{revision}
header:
feedback:
desc: Bir hata mı buldunuz? Öneriler? Fikirler? İnceleme?
title: Geri bildirim
help: Yardım
logout: Çıkış yap
ordergroup: Benim sipariş grubum
Expand Down Expand Up @@ -1267,9 +1256,6 @@ tr:
title: Yeni şifre
mailer:
dateformat: "%d %b"
feedback:
header: "%{user} tarafından %{date} tarihinde yazıldı:"
subject: Foodsoft için geri bildirim
from_via_foodsoft: "%{name} Foodsoft aracılığıyla"
invite:
subject: Foodcoop Davetiyesi
Expand Down
4 changes: 0 additions & 4 deletions config/routes.rb
Expand Up @@ -288,10 +288,6 @@
end
end

############## Feedback

resource :feedback, only: %i[new create], controller: 'feedback'

############## The rest

resources :users, only: [:index]
Expand Down

0 comments on commit bc329fe

Please sign in to comment.