Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle update #561

Merged
merged 1 commit into from
Oct 13, 2018
Merged

Bundle update #561

merged 1 commit into from
Oct 13, 2018

Conversation

wvengen
Copy link
Member

@wvengen wvengen commented Oct 11, 2018

Updated dependencies require Ruby 2.3 or higher.

I propose to do a new release sometime not far long off (mentioning the new required Ruby version).

  • Fix wiki rendering.
  • Update mysql2 gem.

@wvengen wvengen changed the title Bundle update (CVE-2018-3760, requires Ruby 2.3) Bundle update Oct 11, 2018
@wvengen wvengen requested a review from paroga October 11, 2018 20:07
@wvengen wvengen force-pushed the feature/bundle-update branch 2 times, most recently from c5f5bc4 to 56070ab Compare October 11, 2018 20:30
Gemfile.lock Outdated
mono_logger (1.1.0)
multi_json (1.12.2)
multi_json (1.13.1)
mysql2 (0.4.9)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see mysql2 at 0.4.10 since it includes a buildfix for newer mysql versions.

What do you think about a more aggressive dependency update in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated everything, and put back some gem versions that gave problems. This included the mysql2 gem :( where ActiveRecord was mentioning that the required mysql gem wasn't loaded.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try if 0.4.10 works, thanks for mentioning!

@wvengen wvengen merged commit d9ae0d1 into master Oct 13, 2018
@wvengen wvengen deleted the feature/bundle-update branch October 13, 2018 18:04
johonas pushed a commit to johonas/foodsoft that referenced this pull request Dec 17, 2018
* https://github.com/foodcoops/foodsoft: (33 commits)
Fix financial_links table in schema.rb
API v1 navigation endpoint
API v1 config endpoint
API v1 user endpoint
Prepare for API v1 (PR foodcoops#570)
Bundle update (CVE-2018-3760, requires Ruby 2.3, PR foodcoops#561)
fix auto_close_and_send_min_quantity
Fix internal server error at invoices
Add import route for bank_transactions
Add short name to FinancialTransactionType
Add edit functionality for financial links
Add model and views for bank accounts
improve usability when ordering (PR foodcoops#552)
Add format helper for currency
Refactor FoodsoftFile to reuse the code later
Remove deprecated Gemnasium badge
Fix balancing with financial_transaction_types
Make the site_map the default view when showing all wiki pages
Add missing brackets to the Message-ID of emails
Add missing development dependency to docs
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants