Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to recent version #905

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Update to recent version #905

merged 1 commit into from
Dec 30, 2021

Conversation

kidhab
Copy link
Contributor

@kidhab kidhab commented Dec 20, 2021

No description provided.

@wvengen
Copy link
Member

wvengen commented Dec 24, 2021

That sounds like a good idea.
The Dockerfiles already use 2.6 so don't need updating.
Does .ruby-version support omitting the patch level?

@kidhab
Copy link
Contributor Author

kidhab commented Dec 26, 2021

The file's contents only representing a string of the Ruby version to use with this project. I assume it's usualy the first place to look at if you want to know what Ruby version a project uses. Also (and maybe more importantly) RVM and Rbenv will automatically detect it and set the correct Ruby version.
So yes, it should be save to omit a version as long as the new one is working with the Foodsoft.

@wvengen
Copy link
Member

wvengen commented Dec 28, 2021

So, anything against 2.6?

@kidhab
Copy link
Contributor Author

kidhab commented Dec 30, 2021

I think I missunderstood you. Do you ask if it's save to remove the patch level from the .ruby-version file, don't you?
In order to work like expected the version has to be complete including the patch level.

E.g. rbenv parses the file and uses precisely that included version for running the application.

@wvengen
Copy link
Member

wvengen commented Dec 30, 2021

In order to work like expected the version has to be complete including the patch level.

Thanks, that's what I wanted to check!

@wvengen wvengen merged commit 8289886 into foodcoops:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants