Updated: Make showing value add tax in success mail optional #869
Conversation
…rmany not necessary transfer taxes and therefor not necessary to show them in the mails. This commit provides an option in the config to turn showing taxes on and off.
mrothauer
added this to Fertig für v3.6 (in develop-branch)
in Roadmap v3.6 (Summer Release 2023)
| @@ -52,20 +52,16 @@ | |||
| <tbody> | |||
|
|
|||
|
|
|||
| <tr><td style="padding-top:20px;"> | |||
There was a problem hiding this comment.
I left the padding here before, because if you move it into the bracket.
|
|
||
| <?php if (Configure::read('app.sendTaxViaMail')) { ?> | ||
|
|
||
| <?php if (Configure::read('app.showTaxInOrderConfirmationEmail')) { ?> | ||
|
|
There was a problem hiding this comment.
here - into this bracket, then the next message will not have a padding to the table before, which leaves it sticking together, which does not look nice in the email.
There was a problem hiding this comment.
sorry, it was a bit hard to read and I thought it was an error.
should be ok now:
https://github.com/foodcoopshop/foodcoopshop/blob/develop/templates/email/html/order_successful_self_service.php
Very much welcome, no worries - you can edit and change whatever you like, already happy to see this in the next release. Thanks for including it! |
mrothauer
removed this from Fertig für v3.6 (in develop-branch)
in Roadmap v3.6 (Summer Release 2023)
mrothauer
added this to Fertig für v3.5 (in develop-branch)
in Roadmap v3.5 (Autumn Release 2022)
Depending on the value add tax limit (Umsatzsteuergrenze) it is in Germany not necessary transfer taxes and therefor not necessary to show them in the mails. This commit provides an option in the config to turn showing taxes on and off.
@MaxGitHubAccount Thank you for your PR. Sorry, I wanted to add some commits to your PR and I ended up in creating a new branch and therefore this new PR.
I made some code cleaning.