Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using server name as a variable in chat, join, and leave messages #3

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

unilock
Copy link
Contributor

@unilock unilock commented Aug 11, 2022

might be a good idea to make changes to default config as well
closes #2

(had to update maven-shade-plugin to get it to build)

Signed-off-by: unilock <unilock@fennet.rentals>
Signed-off-by: unilock <unilock@fennet.rentals>
@fooooooooooooooo fooooooooooooooo merged commit 6b3dada into fooooooooooooooo:master Aug 15, 2022
@fooooooooooooooo
Copy link
Owner

wicked

@unilock
Copy link
Contributor Author

unilock commented Aug 15, 2022

I opened a similiar pull request on velocity-chat, and the author suggested that it would make more sense to listen to ServerConnectedEvent rather than PlayerChooseInitialServerEvent for detecting when a player joins a backend server, as the latter is meant to be used when wanting to change the server a client is connecting to.

This makes sense to me, and it would allow merging the onConnect() and onServerConnect() listeners as well (as ServerConnectedEvent fires whenever a player joins a backend server via the proxy, regardless of whether they were already connected to the proxy). Though I'm not 100% sure if this would be desired?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Allow using "{current}" variable in other contexts
2 participants