Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sorting arrow is misplaced in latest Firefox (Windows) #2

Closed
cocinerox opened this issue Dec 4, 2012 · 6 comments
Closed

The sorting arrow is misplaced in latest Firefox (Windows) #2

cocinerox opened this issue Dec 4, 2012 · 6 comments
Assignees

Comments

@cocinerox
Copy link

Could you check it? Thanks.
BTW superb effort!

@ghost ghost assigned bradvin Dec 5, 2012
@bradvin
Copy link
Member

bradvin commented Dec 5, 2012

thanks for the heads up - i will look into now - probably just a css issue

@bradvin
Copy link
Member

bradvin commented Dec 6, 2012

this has been fixed. I also made the arrow images into a sprite and added a new image for a "sortable" state so you can easily see which columns you are able to sort

@bradvin bradvin closed this as completed Dec 6, 2012
@cocinerox
Copy link
Author

Works as expected, thanks!
However, I'd suggest to replace Line 51 in footable.sortable.js with

if ($th.find('> span.'+cls.indicator).length == 0) {
    $('<span />').addClass(cls.indicator).appendTo($th);
}

to prevent displaying multiple indicators when $('table').footable(); is called more than one time.

@fooplugins
Copy link
Collaborator

cool, thanks - I will add that check in, but why are you calling $('table').footable(); twice? That should only ever be called once for each page load.

@cocinerox
Copy link
Author

When adding tables dinamically it's simpler to call it after each table.

@bradvin
Copy link
Member

bradvin commented Dec 13, 2012

I added a check into the base footable js file, so if the table has already been initialized by footable it does not do it again

that should solve your problem

steveush added a commit that referenced this issue Feb 23, 2013
Adding in some commits Brad made to master so I can make my merging life
easier.

#1 Changes for checking target of td click so links don't trigger
expand/collapse
#2 Updates to demo2.htm to include links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants