Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] - PLEASE Make Scroll Bar Wider, and Maybe Static (do not fade away) #2111

Closed
Eddiiie opened this issue Sep 10, 2017 · 11 comments
Closed
Labels
done Done but not yet released request Feature request

Comments

@Eddiiie
Copy link

Eddiiie commented Sep 10, 2017

Hi,
Thank you everyone for creating Octoprint.

As I get older things are getting smaller. Screen size is increasing but font size is decreasing. lol

The scroll bar on the Files list drives me nuts. It is SO small and it disappears at the most inconvenient times. Would it be possible and acceptable to make this scroll bar wider and make it stay? So many times I miss it and wind up highlighting all the text, reversing the background on the text, pain.

In fact, in general, keep all scroll bars big. To me, it is worth the space on the screen for easier control. Who came up with the idea that scroll bars are just too big? I mean in general... :)

Thank you for your consideration!

@GitIssueBot GitIssueBot added the request Feature request label Sep 10, 2017
@ntoff
Copy link
Contributor

ntoff commented Sep 11, 2017

I find myself using the "Files" section less and less, have you tried the File Manager plugin? http://plugins.octoprint.org/plugins/filemanager/ I don't remember off the top of my head how well the scroll bar works but it's definitely more user friendly than the default tiny little box (especially on my tablet that is too big for touchUI but too small for the default UI).

@BillyBlaze
Copy link
Member

OT: TouchUI will introduce customisation of fonts in the upcoming release

@JohnOCFII
Copy link

The scroll bar on the Files list drives me nuts. It is SO small and it disappears at the most inconvenient times. Would it be possible and acceptable to make this scroll bar wider and make it stay? So many times I miss it and wind up highlighting all the text, reversing the background on the text, pain.

What operating system are you using? If you are using MacOS, you can change a setting to keep scroll bars always visible. This is in System Preferences --> General on your Mac.

@Eddiiie
Copy link
Author

Eddiiie commented Sep 12, 2017 via email

foosel added a commit that referenced this issue Oct 13, 2017
Increased scrollbar width of file list and plugin repository list to
10px (from 5px). Fixed scroll bar hiding itself on initialization due to
alwaysVisible not properly persisting the initial binding.

Enhance knockout binding syntax for slimScrolledForeach: slimscroll
initialization parameters may now be provided during data binding via
the additional slimscroll property accepted as part of the extended
foreach syntax, e.g.

slimScrolledForEach: {data: ..., slimscroll: {alwaysVisible: true, ...}}

Implements #2111
@foosel
Copy link
Member

foosel commented Oct 17, 2017

Scrollbar is now 10 instead of 5px and does no longer fade out (that it did at all was a bug). Can't go any wider without running into problems with the current layout (and changing that is a whole different undertaking).

Already pushed to maintenance and devel and will be part of the 1.3.6 release.

@foosel foosel added this to the 1.3.6 milestone Oct 17, 2017
@foosel foosel added the done Done but not yet released label Oct 17, 2017
@ntoff
Copy link
Contributor

ntoff commented Oct 17, 2017

I now get this on the maintenance branch

OctoPrint 1.3.6.dev73+gd0aa81c (maintenance branch)

image

@foosel
Copy link
Member

foosel commented Oct 17, 2017

Hm, maybe a caching issue? Not seeing that right now on the exact same version. But I had the feeling there's still something off with the cache validation of the static assets.

@foosel
Copy link
Member

foosel commented Oct 17, 2017

Aaaah... "display is not defined". Yeah, that's a caching issue, but unrelated to this ticket, rather caused by the implementation of #1181. Something I have to look into and already on my TODO list.

@ntoff
Copy link
Contributor

ntoff commented Oct 17, 2017

oh ok, sorry, I saw the slimscrolledforeach and thought the new scroll bar was the reason.

@foosel
Copy link
Member

foosel commented Oct 17, 2017

You and me both on first look, no worries ;) And a fix is incoming.

foosel added a commit that referenced this issue Oct 17, 2017
We might add fields to things like file entries (e.g. "display") and in
such cases want to refetch the list even if the files itself didn't
change, to make sure those new fields are available to the clients.

See #2111 (comment)
@Eddiiie
Copy link
Author

Eddiiie commented Oct 17, 2017

FIXED! THANK YOU! Yes I am yelling!
:)

@Eddiiie Eddiiie closed this as completed Oct 17, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
done Done but not yet released request Feature request
Projects
None yet
Development

No branches or pull requests

6 participants