Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Include hidden finished prints in file search results #2669

Closed
AcHub opened this issue May 30, 2018 · 2 comments
Closed

[Request] Include hidden finished prints in file search results #2669

AcHub opened this issue May 30, 2018 · 2 comments
Labels
done Done but not yet released request Feature request
Milestone

Comments

@AcHub
Copy link

AcHub commented May 30, 2018

I usually hide successfull prints from the file list and I appreciate that Octoprint has this option, as it makes my file list nice and clean.
But when I search for a certain print via the file search I would like the search results to include successful prints as well, as in my case the list of failed or outstanding prints is typically rather short, and I actually only ever use the search bar when I want to find an old successful print that I want to reprint.
So right now I have to deactivate the "hide successful prints from list" option, search the file and then reactivate the option again, which seems like an unnecesary pain.

I guess a feature to include hidden prints in the search results could be just another option besides to "hide successful". Also search results could list matching results from the "fresh" print queue first and then append the matching results from the hidden list, so there will still be a clear separation between "fresh" and "old" prints

@AcHub AcHub changed the title [Request] Include finished prints in file search results [Request] Include hidden finished prints in file search results May 30, 2018
@GitIssueBot GitIssueBot added request Feature request and removed request Feature request labels May 30, 2018
@foosel foosel added this to the 1.3.12 milestone May 3, 2019
@foosel
Copy link
Member

foosel commented May 3, 2019

Implemented by #3126, to be rolled out as part of 1.3.12.

@foosel foosel added the done Done but not yet released label May 3, 2019
@foosel
Copy link
Member

foosel commented Oct 22, 2019

1.3.12 has been released.

@foosel foosel closed this as completed Oct 22, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
done Done but not yet released request Feature request
Projects
None yet
Development

No branches or pull requests

3 participants