Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcode 3D viewer #267

Closed
ochorocho opened this issue Sep 24, 2013 · 6 comments
Closed

gcode 3D viewer #267

ochorocho opened this issue Sep 24, 2013 · 6 comments
Labels
done Done but not yet released plugin available A plugin the implements this is available plugin idea Idea for a plugin request Feature request

Comments

@ochorocho
Copy link

Hey ....

i saw octoprint is using gCodeViewer.
https://github.com/hudbrog/gCodeViewer

gCodeViewer is able to show the uploaded file in 3D.

Was this function removed for some reason or just not implemented?

Thanks.

@foosel
Copy link
Member

foosel commented Sep 30, 2013

It was just not implemented (yet).

@ochorocho
Copy link
Author

:-) .... k .... just tried it. no dice in the first shot.
will give it another try in a few days.
i'll let you know in case i get anywhere with this ..

thanks.

ochorocho

@andrewhodel
Copy link

Could also add https://github.com/joewalnes/gcode-viewer

@ssshake
Copy link

ssshake commented Oct 18, 2014

OK so following up from my other ticket.

Are there plans to implement this and when? If there are no immediate plans and I decide that I have time to dedicate to implement this in my fork, are you willing to review my code and merge it if you're ok with what I've done?

In other words I'm making sure I know it's status before I jump on it and waste my time if it's being released soon anyway.

@foosel
Copy link
Member

foosel commented Oct 18, 2014

It's currently not being worked on at all. The reason is that I'm not yet sure how it would work on mobile devices (I know that OctoPrint's current web interface isn't that mobile friendly, but I want to keep it as functional there as possible nevertheless, and adding a 3D canvas to the ui might render it unusable sluggish on mobile browsers). So if it were to be added it would have to be behind something like a mobile browser detection, possible with some (client-side stored) configuration switch that defaults to off if a mobile browser is detected and the user can then enable if he's certain the device can handle it.

On top of that there's another issue: I'm not completely happy with the mouse handling of the 3d part of the gcode viewer. The dragging stuff for reorienting the item feel very very sluggish and also too freeform. It's hard to describe... what I mean is, when I try to look at the toolpath from the side, it's more likely that everything will end up with the top pointing to something like 45°C to the upper left or something like that - play around with it a bit and I hope you will "feel" what I mean, it doesn't feel "right". So there'd need to be some work done in that department too. My goal would be that it feels like the 3D view in Cura or the in-browser-editor of CoffeeScad.

And last but not least, the gcode viewer version integrated in OctoPrint was heavily modified around new years, to both support multiple extruders and to remove the heavy coupling it previously had to the UI parts. I've been meaning to merge those changes back and turn the thing into a real jquery module or something, but there were always other things (more pressing issues, real life, job change, ...) that kept me from coming around to it.

So -- that about sums it up while it isn't in there right now and while it will probably be not worked on by me personally for some time until everything above there is solved. Of course, patches are always welcome, but be aware that this is not a minor task because -- well, see above.

@foosel foosel modified the milestone: Plugins Mar 23, 2015
@foosel foosel added the plugin idea Idea for a plugin label Mar 10, 2016
@foosel foosel removed this from the Plugins milestone Jun 20, 2018
@jneilliii
Copy link
Contributor

There's a new player in the plugin space for this if you haven't seen it on the Community Forum. From what I've seen over there it seems to work perfectly fine.

https://github.com/Kragrathea/OctoPrint-PrettyGCode

@foosel foosel closed this as completed Mar 31, 2021
@github-actions github-actions bot added the done Done but not yet released label Mar 31, 2021
@LazeMSS LazeMSS added the plugin available A plugin the implements this is available label Mar 31, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
done Done but not yet released plugin available A plugin the implements this is available plugin idea Idea for a plugin request Feature request
Projects
None yet
Development

No branches or pull requests

6 participants