Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.11rc2] UnicodeDecodeError in virtual printer's readline #3105

Closed
sentry-io bot opened this issue Apr 4, 2019 · 4 comments

Comments

Projects
None yet
1 participant
@sentry-io
Copy link

commented Apr 4, 2019

Sentry Issue: SERVER-SX

UnicodeDecodeError: 'ascii' codec can't decode byte 0x80 in position 0: ordinal not in range(128)
  File "octoprint/util/comm.py", line 2730, in _readline
    ret = self._serial.readline()
  File "home/pi/oprint/lib/python2.7/site-packages/octoprint/plugins/virtual_printer/virtual.py", line 1424, in readline
    self._seriallog.info(u">>> {}".format(line.strip()))

Unexpected error while reading from serial port

See also this comment by @trunzoc. Probably caused by something weird in the config.yaml and possibly easily fixed by some more type safety, but waiting for config.yaml excerpt to be sure.

@foosel foosel added this to the 1.3.11 milestone Apr 4, 2019

@foosel

This comment has been minimized.

Copy link
Owner

commented Apr 4, 2019

Reproduced. Default configuration for devel.virtualPrinter.resetLines triggers the issue (and due to hunting down a different bug earlier I didn't have that active).

foosel added a commit that referenced this issue Apr 4, 2019

@foosel

This comment has been minimized.

Copy link
Owner

commented Apr 4, 2019

Fixed by the above commit, ready for 1.3.11rc3

@foosel

This comment has been minimized.

Copy link
Owner

commented Apr 8, 2019

Workaround until RC3:

devel:
  virtualPrinter:
    resetLines:
      - start

in config.yaml

@foosel foosel removed their assignment Apr 8, 2019

@foosel

This comment has been minimized.

Copy link
Owner

commented Apr 11, 2019

1.3.11rc3 is out which should fix this.

@foosel foosel closed this Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.