User info for print job #2576
Merged
User info for print job #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
Adding user information to the printer state so it is possible to retrieve the user who started the current print job. This is a useful information in a multi-user environment. A use case might be a print history where the admin can see who used the printer, e.g. for billing purposes.
How was it tested? How can it be tested by the reviewer?
Started print in the web interface and checked the
printingUserwith the job API.Confirmed that the
printingUserwas set the null after the print finished/failed/was cancelled.Also tested the same with 'print after loading'.
Haven't tested with 'print after slicing'.
Any background context you want to provide?
What are the relevant tickets if any?
#652
#1545
Screenshots (if appropriate)
Further notes
Applied changes you mentioned in #2570. Opened a new PR because I used the
develbranch for my changes in the previous PR.