Cherry V3 EN build guide touchup #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@waffle87 Thank you for updating! It looks good, however, if the firmware not working, we should update https://raw.githubusercontent.com/foostan/qmk_firmware-hex/main/.build/crkbd_rev1_via.hex Could you tell me about the problem with the current firmware? |
Notably issues with RGB and OLEDS, but after having just tested with hardware myself, it seems to all work correctly. I see your github workflow makes use of QMK's docker container, so may have been related avr-gcc version (5.4 until somewhat recently). Or more likely user error hah. Nonetheless, I have reverted the links to original source :^) |
|
Thank you for the detailed information and your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some misc cleanup and additions brought to my attention by #162
Also adds known to be working firmware, as the current binary in the firmware doc has various issues reported by users.