Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printer-friendly version #45

Closed
docksteaderluke opened this issue Feb 24, 2016 · 10 comments
Closed

Printer-friendly version #45

docksteaderluke opened this issue Feb 24, 2016 · 10 comments

Comments

@docksteaderluke
Copy link

This diagram is amazing!

Any chance of arranging it slightly for a more printer-friendly version? It belongs in a frame!

@andreineculau
Copy link
Member

What are we talking about here? define "more printer-friendly"

You already have https://github.com/for-GET/http-decision-diagram/blob/master/httpdd.png, and ultimately you can also just open http://for-get.github.io/http-decision-diagram/httpdd.fsm.html in a browser and press print. What makes these options not printer-friendly?

Let me know and I'll see what I can do.

@docksteaderluke
Copy link
Author

I guess what I mean is that you can print it in a legible way on standard letter-sized paper (8.5x11). Right now when I print it the text is too small. My first thoughts would be to reduce/remove any excess whitespace and enlarge the label text.

@andreineculau
Copy link
Member

hmm, good luck with that (printing everything in a legible way on a letter/A4 sized paper) :)

I would gladly look into a PR's changes, if you manage what you want and send a PR. The current state is the balance that I stroke (the first iteration was too bulky, given the number of the FSM datapoints), but obviously improvements could be found that maybe could come close to your goal. I am skeptical that you would reach your goal. Even the "original" couldn't be printed on a regular paper in a legible way, thus my skepticism.

@dmitriid
Copy link

I'd say it's probably possible to print one section per A4 maintaining a bit of legibility. The entire diagram? Doubtful

@docksteaderluke
Copy link
Author

Hmmm... It was actually pretty close when I first tried to print it. I believe it would be possible to make the necessary modifications. I'll see if I can free up some time to tweak the diagram and submit a PR.

@andreineculau
Copy link
Member

FWIW I have properly fixed all the calculations of coordinates (was a mess!) and also I've updated a bit the font sizes etc. Maybe it's better/worse now for your goal, but the offer still stands obviously: send a PR, and I'll check it out

@andreineculau
Copy link
Member

FWIW went a notch further - added a header and export to PNG/JPEG/SVG buttons

@docksteaderluke
Copy link
Author

Nice!

I'm getting a JavaScript error when running the httpdd.fsm.html file:

Uncaught TypeError: this.toDataURL is not a function - joint.all.js:36623

Also, the "Open as PNG" and "Open as SVG" buttons don't seem to do anything. Maybe as a result of the above error? I'm running Chrome 48.0.2564.109 (64-bit) on OSX 10.11.3.

@andreineculau
Copy link
Member

ignore the error as it doesn't affect the runtime

as for the Open as.. I think chrome was blocking window.open. Should work
now

On Fri, Feb 26, 2016 at 2:35 PM, Luke Docksteader notifications@github.com
wrote:

Nice!

I'm getting a JavaScript error when running the httpdd.fsm.html file:

Uncaught TypeError: this.toDataURL is not a function - joint.all.js:36623

Also, the "Open as PNG" and "Open as SVG" buttons don't seem to do
anything. Maybe as a result of the above error? I'm running Chrome
48.0.2564.109 (64-bit) on OSX 10.11.3.


Reply to this email directly or view it on GitHub
#45 (comment)
.

andreineculau.com http://www.andreineculau.com

@docksteaderluke
Copy link
Author

Works now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants