Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix strict schema matching #124

Open
andreineculau opened this issue May 8, 2022 · 3 comments
Open

fix strict schema matching #124

andreineculau opened this issue May 8, 2022 · 3 comments

Comments

@andreineculau
Copy link
Member

andreineculau commented May 8, 2022

A schema with "$schema": "http://json-schema.org/draft-06/schema" i.e. no trailing # will make jesse believe this is not a draft6 schema, and complain about unsupported schema.

http://json-schema.org/draft-06/schema# is equivalent to http://json-schema.org/draft-06/schema and should be treated as such.

@tsloughter
Copy link

Just came here to say the same thing.

I plan to send a PR to parse the schema url and match the parts, but curious if this really needs to continue to support OTP-19 and 20? Would like to just use uri_string from the stdlib.

@andreineculau
Copy link
Member Author

I think the added value trumps supporting old OTP 19-20. PR appreciated

@gsantana2023
Copy link

I don't think there should be a need to support http://json-schema.org/draft-06/schema without the trailing#. I think that the JSON schema specification strictly uses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants