Move CI away from -rc3 and into "the real thing"

[paulo-ferraz-oliveira]

No description provided.

[andreineculau]

re: #105 (comment)
I remember replying to you, but heck if I know what happened to my reply. I was asking you if you have a clever idea to not need to manually update that, or at least add a check so CI fails when we forget to update.

I have a suggestion around that: since there is a erlang:latest docker image, we could maybe have latest in the list for otp_vsn and then the shell check can be simply if matrix.otp_vsn = latest then ... (pseudo). WDYT?

[paulo-ferraz-oliveira]

WDYT?

Might work, let me try. I wasn't looking at this "latest" part and had even forgotten about that subject 😄

Edit: 4279dac 👈 if this passes, the only question here is "Do we want to keep 24.0 next to latest - which would mean that we'd need to know what latest is, every time -, or are we Okay with a potentially duplicate CI run, currently "24.0 and latest"?

Edit 2: actually, let me try and add some if to it.

[paulo-ferraz-oliveira]

I'll squash everything now. @andreineculau, how'd'you like the end result?

Edit: left some comments here and there, for review clarity.

[andreineculau]

I think it's ok to run make and make test on latest, even though at times it might be redundant. But at times, erlang will publish newer versions than what we're testing against, and then it's good to build and run the tests on that version too.

Vague memory that maybe there are some side-effects or running make elvis docs first. Maybe not in functionality, but speed. Maybe!

[paulo-ferraz-oliveira]

Squashed the removal of some conditionals with existing code and force-pushed...

[andreineculau]

Thanks for the changes! 🎉