Add support for unicode properties in pattern, etc. #112
Conversation
|
I forgot about this for quite awhile, but noticed it in my queue today and took a stab. Please let me know if this will work. |
src/jesse_lib.erl
Outdated
| %% {@link https://www.erlang.org/doc/man/re.html#compile-2. re:compile/2} | ||
| -spec re_options() -> list(). | ||
| re_options() -> | ||
| application:get_env(jesse, re_options, [ucp]). |
There was a problem hiding this comment.
When ucp is enabled, shouldn't unicode be added explicitly as well? It's a bit not clear from the documentation.
There was a problem hiding this comment.
I think you're right that you need both:
1> re:run(<<"fōô"/utf8>>, "^\\w+$", [{capture, none}, ucp, unicode]).
match
2> re:run(<<"fōô"/utf8>>, "^\\w+$", [{capture, none}, ucp]).
nomatchI will update the default and docs.
There was a problem hiding this comment.
that makes me think that it might be nice to have at least some test that showcases this feature
There was a problem hiding this comment.
I agree, I will write some eunit tests for these new utility functions.
There was a problem hiding this comment.
Done! The last commit (388cfa6) should address your concerns and suggestions. Thanks!
nalundgaard
force-pushed
the
104_re_options_default_ucp
branch
from
1160a9f
to
cb7ee7c
Compare
Resolves for-GET#104. Adds support for unicode properties "pattern" and "patternProperties" by adding `re_options` to the `jesse` application environment and making all uses of `re:run/2` consult it. This effectively changes the previously hard-coded `unicode` option to `ucp`, but allows restoring the previous behavior (for better performance) by setting `re_options` to `[unicode]` instead of `[ucp]`.
nalundgaard
force-pushed
the
104_re_options_default_ucp
branch
from
cb7ee7c
to
388cfa6
Compare
|
LGTM, thanks. Let's see if @andreineculau have any opinions |
|
I'll merge it on Tuesday 14th, if noone objects before that |
Resolves #104.
Adds support for unicode properties "pattern" and "patternProperties" by adding
re_optionsto thejesseapplication environment and making all uses ofre:run/2consult it. This effectively changes the previously hard-codedunicodeoption toucp, but allows restoring the previous behavior (for better performance) by settingre_optionsto[unicode]instead of[ucp].