Fix some bugs reported #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only run tests for each minor otp version for 3 latest major releases. This is to reduce the CI times.
seriyps
referenced
this pull request
Feb 17, 2022
|
Any updates on this? |
andreineculau
approved these changes
May 7, 2022
|
Thanks as always 🙏 @seriyps Not sure though about 468eba5. If my memory serves well, there have been some bugs present in minor versions. We know that the current state is green in those versions, but we don't know if future code changes will. And since we have no idea in which envs jesse is used, it may mean we break those envs. And we do that to shave ~5 minutes (removing 9 versions out of 22). While I personally favour running not-bleeding-but-still-new versions of my dependencies, I know many don't want or cannot do that, so I'd reckon there are still many deployments out there on e.g. OTP 19. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117 and c56fef4#commitcomment-66651833