Avoid deprecated http_uri functions for OTP 21+ #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In PR description you said
but in fact you are using it in OTP 21+. I think PR description is wrong, not the code (uri_string was introduced in OTP21). It looks good for me. Let's wait 1-2 days if anyone else have any comments. Otherwise I will merge it 04 Mar. |
Oops! I will fix the description ;) |
andreineculau
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
Thanks a bunch @shino !
Left a few improvement comments, but I don't see any blockers.
| %% Absolute file: | ||
| {error, {no_default_port, file, Ref}} -> | ||
| case parse_ref(RefBin) of | ||
| {absolute, Ref} -> | ||
| Ref; | ||
| %% Relative |
There was a problem hiding this comment.
remove the %% Relative comment. it is now nicely readable in the returned tuple 👏
|
@andreineculau Thanks a lot for your comments!! |
seriyps
approved these changes
Mar 4, 2020
|
Thank you @shino |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with OTP 23-rc1, deprecated warnings are emmited for two http_uri functions,
parseanddecode.In this PR:
parseis replaced byuri_string:parse.decodeis replaced by module privatehex_decodefunction which is based onhttp_uri:decodecode, because I can not find alternative inuri_stringmodule.